From 6a4e810800d4e74fd8e59211750d9d07107f3586 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan <67804911+iamejaaz@users.noreply.github.com> Date: Wed, 25 Mar 2026 14:41:36 +0530 Subject: [PATCH] Revert "fix: use `JSON.parse()` for filter processing" --- frappe/desk/doctype/workspace/workspace.py | 12 ------------ frappe/public/js/frappe/utils/utils.js | 8 +------- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/frappe/desk/doctype/workspace/workspace.py b/frappe/desk/doctype/workspace/workspace.py index 8a9f8cee17..7b6a4f92b1 100644 --- a/frappe/desk/doctype/workspace/workspace.py +++ b/frappe/desk/doctype/workspace/workspace.py @@ -76,18 +76,6 @@ class Workspace(Document): if self.public and not is_workspace_manager() and not disable_saving_as_public(): frappe.throw(_("You need to be Workspace Manager to edit this document")) - - if ( - not self.public - and self.for_user - and self.for_user != frappe.session.user - and not is_workspace_manager() - ): - frappe.throw( - _("You are not allowed to edit this workspace"), - frappe.PermissionError, - ) - if self.has_value_changed("title"): validate_route_conflict(self.doctype, self.title) else: diff --git a/frappe/public/js/frappe/utils/utils.js b/frappe/public/js/frappe/utils/utils.js index 674ff8c8c6..efb138ebaf 100644 --- a/frappe/public/js/frappe/utils/utils.js +++ b/frappe/public/js/frappe/utils/utils.js @@ -1933,13 +1933,7 @@ Object.assign(frappe.utils, { process_filter_expression(filter) { let filters = []; - if (filter) { - try { - filters = JSON.parse(filter); - } catch { - console.warn("Invalid JSON in filter expression", filter); - } - } + filters = filter ? new Function(`return ${filter}`)() : []; return this.cleanup_filters(filters); }, cleanup_filters(filters) {