vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

perf(remove_script_and_style): caching for performance

Browse source
This commit is contained in:
Saif Ur Rehman 2023-10-23 00:25:42 +05:00
parent 6a9fee1b83
commit 6aa795b855
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
frappe/public/js/frappe/dom.js
View file

@ -32,7 +32,26 @@ frappe.dom = {
// execute the script globally
document.getElementsByTagName("head")[0].appendChild(el);
},
_remove_script_and_style_cache: {},
remove_script_and_style: function (txt) {
// do not parse if html tag not found (for performance and cache memory reduction)
if (!txt || !txt.includes("<")) {
return txt;
}
// cache already processed strings since DOMParser.parseFromString is relatively slow
let cached = this._remove_script_and_style_cache[txt];
if (cached) {
// true means no evil tags, return string as is undisturbed
if (cached === true) {
return txt;
} else {
return cached;
}
}
const evil_tags = ["script", "style", "noscript", "title", "meta", "base", "head"];
const parser = new DOMParser();
const doc = parser.parseFromString(txt, "text/html");
@ -55,9 +74,11 @@ frappe.dom = {
}
if (found) {
this._remove_script_and_style_cache[txt] = body.innerHTML;
return body.innerHTML;
} else {
// don't disturb
this._remove_script_and_style_cache[txt] = true;
return txt;
}
},