From 6ad81dc690983a066b152e2fdf8ccb0f44da59a5 Mon Sep 17 00:00:00 2001
From: prssanna <prssud@gmail.com>
Date: Wed, 26 Aug 2020 23:10:42 +0530
Subject: [PATCH] fix: don't set undefined filters

---
 frappe/public/js/frappe/ui/filters/filter_list.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/frappe/public/js/frappe/ui/filters/filter_list.js b/frappe/public/js/frappe/ui/filters/filter_list.js
index 36d19398e3..571edd0ce9 100644
--- a/frappe/public/js/frappe/ui/filters/filter_list.js
+++ b/frappe/public/js/frappe/ui/filters/filter_list.js
@@ -64,7 +64,6 @@ frappe.ui.FilterGroup = class {
 
 			if (!this.wrapper) {
 				this.wrapper = $('.filter-popover');
-				console.log('shownn', this.filters);
 				if (hide_empty_filters) {
 					this.toggle_empty_filters(false);
 					this.add_filters_to_popover(this.filters);
@@ -76,8 +75,8 @@ frappe.ui.FilterGroup = class {
 		});
 
 		this.filter_button.on('hidden.bs.popover', (e) => {
-			this.on_change();
 			this.update_filters();
+			this.on_change();
 		});
 
 		$(window).on('hashchange', () => {
@@ -243,7 +242,9 @@ frappe.ui.FilterGroup = class {
 	}
 
 	update_filters() {
-		this.filters = this.filters.filter((f) => f.field); // remove hidden filters
+		// remove hidden filters and undefined filters
+		this.filters.map(f => !f.get_selected_value() && f.remove());
+		this.filters = this.filters.filter(f => f.get_selected_value() && f.field);
 		this.update_filter_button();
 		this.filters.length === 0 &&
 			this.toggle_empty_filters(true);