From 6b3d3b57dc768fd8f4646c28fa138086247fdd53 Mon Sep 17 00:00:00 2001 From: Aditya Hase Date: Thu, 7 Mar 2019 12:56:25 +0530 Subject: [PATCH] fix(desk): Ignore list view settings when not fetched Views extending ListView inherit methods (sometimes without overriding) For such cases check if list_view_settings property is available first --- frappe/public/js/frappe/list/list_sidebar.js | 2 +- frappe/public/js/frappe/list/list_view.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/list/list_sidebar.js b/frappe/public/js/frappe/list/list_sidebar.js index 74ea628e82..20f1f030d4 100644 --- a/frappe/public/js/frappe/list/list_sidebar.js +++ b/frappe/public/js/frappe/list/list_sidebar.js @@ -258,7 +258,7 @@ frappe.views.ListSidebar = class ListSidebar { get_stats() { var me = this; - if (this.list_view.list_view_settings.disable_sidebar_stats) { + if (this.list_view.list_view_settings && this.list_view.list_view_settings.disable_sidebar_stats) { return; } frappe.call({ diff --git a/frappe/public/js/frappe/list/list_view.js b/frappe/public/js/frappe/list/list_view.js index d4c411fce3..1f4537cb71 100644 --- a/frappe/public/js/frappe/list/list_view.js +++ b/frappe/public/js/frappe/list/list_view.js @@ -294,7 +294,7 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList { } freeze() { - if (!this.list_view_settings.disable_count) { + if (this.list_view_settings && !this.list_view_settings.disable_count) { this.$result.find('.list-count').html(`${__('Refreshing')}...`); } }