From 6e880bdcfe0bbc03cd9ba89a2d41b8f2b528cd12 Mon Sep 17 00:00:00 2001 From: Hussain Nagaria <34810212+NagariaHussain@users.noreply.github.com> Date: Mon, 11 Aug 2025 17:19:21 +0530 Subject: [PATCH] fix: version diff for empty datetime fields (#33605) * fix: version diff for empty datetime fields * fix: remove debug print --- frappe/core/doctype/version/version.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/core/doctype/version/version.py b/frappe/core/doctype/version/version.py index 25c3c096b6..d3ee8ca22d 100644 --- a/frappe/core/doctype/version/version.py +++ b/frappe/core/doctype/version/version.py @@ -4,7 +4,7 @@ import json import frappe -from frappe.model import no_value_fields, table_fields +from frappe.model import datetime_fields, no_value_fields, table_fields from frappe.model.document import Document from frappe.utils import cstr @@ -120,6 +120,10 @@ def get_diff(old, new, for_child=False, compare_cancelled=False): if df.fieldtype in ("Link", "Dynamic Link"): old_value, new_value = cstr(old_value), cstr(new_value) + if df.fieldtype in datetime_fields: + if old_value is None and new_value == "": + new_value = None + if not for_child and df.fieldtype in table_fields: old_rows_by_name = {} for d in old_value: