From 6ec5c05e4e25416115e462d90f53d23e82a7d422 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 24 Aug 2022 14:24:10 +0530 Subject: [PATCH] test: simplify user addition test --- frappe/tests/test_commands.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/frappe/tests/test_commands.py b/frappe/tests/test_commands.py index 8c4099b2df..9fd505a9c3 100644 --- a/frappe/tests/test_commands.py +++ b/frappe/tests/test_commands.py @@ -694,18 +694,12 @@ class TestSiteMigration(BaseTestCommands): class TestAddNewUser(BaseTestCommands): def test_create_user(self): self.execute( - f"bench --site {TEST_SITE} add-user test@gmail.com --first-name test --last-name test --password 123 --user-type 'System User' --add-role 'Accounts User' --add-role 'Sales User'" + "bench --site {site} add-user test@gmail.com --first-name test --last-name test --password 123 --user-type 'System User' --add-role 'Accounts User' --add-role 'Sales User'" ) self.assertEqual(self.returncode, 0) - roles = [] user = frappe.get_doc("User", "test@gmail.com") - for i in user.roles: - role = frappe.get_doc("Has Role", i.name) - roles.append(role.role) - self.assertEqual(user.name, "test@gmail.com") - self.assertIn("Accounts User", roles) - self.assertIn("Sales User", roles) - self.assertTrue(len(roles) == 2) + roles = {r.role for r in user.roles} + self.assertEqual({"Accounts User", "Sales User"}, roles) class TestBenchBuild(BaseTestCommands):