vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Don't assign returned values if row is deleted (#25806)

Browse source
This commit is contained in:
Nabin Hait 2024-04-06 18:07:17 +05:30 • committed by GitHub
parent 4a99f09fcd
commit 7252d1561f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
frappe/public/js/frappe/form/form.js
View file

@ -1730,17 +1730,19 @@ frappe.ui.form.Form = class FrappeForm {
if (opts.child) {
// update child doc
opts.child = locals[opts.child.doctype][opts.child.name];
var std_field_list = ["doctype"]
.concat(frappe.model.std_fields_list)
.concat(frappe.model.child_table_field_list);
for (var key in r.message) {
if (std_field_list.indexOf(key) === -1) {
opts.child[key] = r.message[key];
// if child row is deleted, don't update
if (opts.child) {
var std_field_list = ["doctype"]
.concat(frappe.model.std_fields_list)
.concat(frappe.model.child_table_field_list);
for (var key in r.message) {
if (std_field_list.indexOf(key) === -1) {
opts.child[key] = r.message[key];
}
}
}
me.fields_dict[opts.child.parentfield].refresh();
me.fields_dict[opts.child.parentfield].refresh();
}
} else {
// update parent doc
me.set_value(r.message);