From 192cba460ed6faa1760274769ac9f11ad668b500 Mon Sep 17 00:00:00 2001 From: Sahil Khan Date: Fri, 8 Feb 2019 18:22:01 +0530 Subject: [PATCH 1/2] fix(email_group): show correct total_subscribers after inserting or deleting email group members --- .../doctype/email_group_member/email_group_member.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/frappe/email/doctype/email_group_member/email_group_member.py b/frappe/email/doctype/email_group_member/email_group_member.py index d0968425d0..8bdff4e516 100644 --- a/frappe/email/doctype/email_group_member/email_group_member.py +++ b/frappe/email/doctype/email_group_member/email_group_member.py @@ -7,7 +7,15 @@ import frappe from frappe.model.document import Document class EmailGroupMember(Document): - pass + def after_delete(self): + print("*"*50, "delete") + email_group = frappe.get_doc('Email Group', self.email_group) + email_group.update_total_subscribers() + + def after_insert(self): + print("*"*50, "add") + email_group = frappe.get_doc('Email Group', self.email_group) + email_group.update_total_subscribers() def after_doctype_insert(): - frappe.db.add_unique("Email Group Member", ("email_group", "email")) \ No newline at end of file + frappe.db.add_unique("Email Group Member", ("email_group", "email")) From 91ac1608db9eb71c74a1bd1471d3174a950dceeb Mon Sep 17 00:00:00 2001 From: Sahil Khan Date: Fri, 8 Feb 2019 18:26:04 +0530 Subject: [PATCH 2/2] fix: remove print statements --- frappe/email/doctype/email_group_member/email_group_member.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/frappe/email/doctype/email_group_member/email_group_member.py b/frappe/email/doctype/email_group_member/email_group_member.py index 8bdff4e516..23b279e755 100644 --- a/frappe/email/doctype/email_group_member/email_group_member.py +++ b/frappe/email/doctype/email_group_member/email_group_member.py @@ -8,12 +8,10 @@ from frappe.model.document import Document class EmailGroupMember(Document): def after_delete(self): - print("*"*50, "delete") email_group = frappe.get_doc('Email Group', self.email_group) email_group.update_total_subscribers() def after_insert(self): - print("*"*50, "add") email_group = frappe.get_doc('Email Group', self.email_group) email_group.update_total_subscribers()