From 73a04e9a5d20dcf8dd75c403cd20a6c0de09578d Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Thu, 31 Oct 2024 19:52:47 +0100 Subject: [PATCH] refactor(mapper): use `doc.check_permission` (#28316) --- frappe/model/mapper.py | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/frappe/model/mapper.py b/frappe/model/mapper.py index 1aab459c24..8aca4c4380 100644 --- a/frappe/model/mapper.py +++ b/frappe/model/mapper.py @@ -90,12 +90,8 @@ def get_mapped_doc( else: ret_doc = target_doc - if ( - not apply_strict_user_permissions - and not ignore_permissions - and not target_doc.has_permission("create") - ): - target_doc.raise_no_permission_to("create") + if not apply_strict_user_permissions and not ignore_permissions: + target_doc.check_permission("create") if cached: source_doc = frappe.get_cached_doc(from_doctype, from_docname) @@ -103,8 +99,7 @@ def get_mapped_doc( source_doc = frappe.get_doc(from_doctype, from_docname) if not ignore_permissions: - if not source_doc.has_permission("read"): - source_doc.raise_no_permission_to("read") + source_doc.check_permission("read") ret_doc.run_method("before_mapping", source_doc, table_maps) @@ -178,8 +173,8 @@ def get_mapped_doc( ret_doc.run_method("after_mapping", source_doc) ret_doc.set_onload("load_after_mapping", True) - if apply_strict_user_permissions and not ignore_permissions and not ret_doc.has_permission("create"): - ret_doc.raise_no_permission_to("create") + if apply_strict_user_permissions and not ignore_permissions: + ret_doc.check_permission("create") return ret_doc