vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Revert "fix(client): add stronger checks in save and set_value endpoints"

Browse source
This commit is contained in:
Aarol D'Souza 2026-04-24 20:09:37 +05:30 • committed by GitHub
parent 6284ad13cd
commit 74f125c360
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
frappe/client.py
View file

@ -189,21 +189,18 @@ def set_value(doctype: str, name: str | int, fieldname: str | dict[str, Any], va
:param fieldname: fieldname string or JSON / dict with key value pair
:param value: value if fieldname is JSON / dict"""
values = {}
if value is not None:
values = {fieldname: value}
elif isinstance(fieldname, dict):
if fieldname in (frappe.model.default_fields + frappe.model.child_table_fields):
frappe.throw(_("Cannot edit standard fields"))
if not value:
values = fieldname
elif isinstance(fieldname, str):
if isinstance(fieldname, str):
try:
values = json.loads(fieldname)
except ValueError:
values = {fieldname: ""}
forbidden = set(frappe.model.default_fields + frappe.model.child_table_fields)
for field in values:
if field in forbidden:
frappe.throw(_("Cannot edit standard fields"))
else:
values = {fieldname: value}
# check for child table doctype
if not frappe.get_meta(doctype).istable:
@ -253,11 +250,6 @@ def save(doc: str | dict[str, Any]):
if isinstance(doc, str):
doc = json.loads(doc)
forbidden = {"docstatus", "idx"}
for field in doc:
if field in forbidden:
frappe.throw(_("Cannot edit standard fields"))
doc = frappe.get_doc(doc)
doc.save()