Merge pull request #38976 from KerollesFathy/fix/prevent-standard-report-without-developer-mode

fix(report): prevent standard report creation when developer mode is off
This commit is contained in:
Ejaaz Khan 2026-04-29 16:36:48 +05:30 committed by GitHub
commit 74f8cec1c3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -74,8 +74,7 @@ class Report(Document):
frappe.throw(_("Cannot edit a standard report. Please duplicate and create a new report"))
if self.is_standard == "Yes":
if frappe.session.user != "Administrator":
frappe.throw(_("Only Administrator can save a standard report. Please rename and save."))
self.validate_standard_report()
if self.report_type == "Report Builder":
self.update_report_json()
@ -412,6 +411,13 @@ class Report(Document):
return data
def validate_standard_report(self):
if frappe.session.user != "Administrator":
frappe.throw(_("Only Administrator can save a standard report. Please rename and save."))
if not cint(frappe.conf.developer_mode):
frappe.throw(_("Standard reports can only be created in developer mode."))
def validate_default_print_format(self):
pf = frappe.db.get_value(
"Print Format",