vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: restrict doctypes to update when creating custom fields

Browse source
This commit is contained in:
Sagar Vora 2025-03-08 12:12:43 +05:30
parent 77852fd11f
commit 7503db4160
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/custom/doctype/custom_field/custom_field.py
View file

@ -333,7 +333,7 @@ def create_custom_fields(custom_fields: dict, ignore_validate=False, update=True
doctypes = (doctypes,)
for doctype in doctypes:
doctypes_to_update.add(doctype)
updated = False
for df in fields:
field = frappe.db.get_value("Custom Field", {"dt": doctype, "fieldname": df["fieldname"]})
@ -342,15 +342,25 @@ def create_custom_fields(custom_fields: dict, ignore_validate=False, update=True
df = df.copy()
df["owner"] = "Administrator"
create_custom_field(doctype, df, ignore_validate=ignore_validate)
updated = True
except frappe.exceptions.DuplicateEntryError:
pass
elif update:
custom_field = frappe.get_doc("Custom Field", field)
custom_field.flags.ignore_validate = ignore_validate
original_values = custom_field.__dict__.copy()
custom_field.update(df)
custom_field.save()
if original_values != custom_field.__dict__:
if ignore_validate:
custom_field.flags.ignore_validate = True
custom_field.save()
updated = True
if updated:
doctypes_to_update.add(doctype)
for doctype in doctypes_to_update:
frappe.clear_cache(doctype=doctype)