From 7572e6fe459c9d3735b9b60cffbba58998ffe08a Mon Sep 17 00:00:00 2001 From: Kaushal Shriwas <64089478+kaulith@users.noreply.github.com> Date: Fri, 17 Apr 2026 00:22:33 +0530 Subject: [PATCH] feat: add aria-label to sidebar notification count --- frappe/public/js/frappe/ui/notifications/notifications.js | 7 +++++-- frappe/public/js/frappe/ui/sidebar/sidebar.js | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/ui/notifications/notifications.js b/frappe/public/js/frappe/ui/notifications/notifications.js index c759c3c01e..b2179e7e61 100644 --- a/frappe/public/js/frappe/ui/notifications/notifications.js +++ b/frappe/public/js/frappe/ui/notifications/notifications.js @@ -402,9 +402,12 @@ class NotificationsView extends BaseNotificationsView { if (!$suffix?.length) return; if (count > 0) { - $suffix.text(count > 99 ? "99+" : count).removeClass("hidden"); + $suffix + .text(count > 99 ? "99+" : count) + .attr("aria-label", __("{0} unread notifications", [count])) + .removeClass("hidden"); } else { - $suffix.addClass("hidden"); + $suffix.removeAttr("aria-label").addClass("hidden"); } } diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar.js b/frappe/public/js/frappe/ui/sidebar/sidebar.js index 7f3a78aab5..b3d6099768 100644 --- a/frappe/public/js/frappe/ui/sidebar/sidebar.js +++ b/frappe/public/js/frappe/ui/sidebar/sidebar.js @@ -487,7 +487,7 @@ frappe.ui.Sidebar = class Sidebar { standard: true, type: "Button", class: "sidebar-notification hidden", - suffix: "", + suffix: "", onClick: () => { const $dropdown = this.wrapper.find(".dropdown-notifications"); $dropdown.toggleClass("hidden");