From d80006ac59ecfd73fc3ff415de037ab637be8605 Mon Sep 17 00:00:00 2001
From: sokumon <sohamkulkarns9@gmail.com>
Date: Fri, 17 Jan 2025 16:18:05 +0530
Subject: [PATCH 1/2] fix(ux): helpful links added while creating email account

---
 .../email/doctype/email_account/email_account.js | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/frappe/email/doctype/email_account/email_account.js b/frappe/email/doctype/email_account/email_account.js
index f76a175b24..d8e0f57506 100644
--- a/frappe/email/doctype/email_account/email_account.js
+++ b/frappe/email/doctype/email_account/email_account.js
@@ -126,6 +126,22 @@ frappe.ui.form.on("Email Account", {
 				frm.set_value(key, value);
 			});
 		}
+		// For better UX
+		if (frm.doc.service == "GMail") {
+			console.log("hello");
+			frm.set_df_property(
+				"password",
+				"description",
+				'To generate password visit <a href="https://knowledge.workspace.google.com/kb/how-to-create-app-passwords-000009237"> here'
+			);
+		}
+		if (frm.doc.service == "Frappe Mail") {
+			frm.set_df_property(
+				"api_secret",
+				"description",
+				'To know more visit <a href="https://github.com/frappe/mail"> here'
+			);
+		}
 	},
 
 	use_imap: function (frm) {

From 8ce7b212de55494f1ef8623f049e5b6c461286e4 Mon Sep 17 00:00:00 2001
From: sokumon <sohamkulkarns9@gmail.com>
Date: Sat, 18 Jan 2025 13:08:30 +0530
Subject: [PATCH 2/2] fix: refactored helpful links

---
 .../doctype/email_account/email_account.js    | 37 ++++++++++---------
 1 file changed, 20 insertions(+), 17 deletions(-)

diff --git a/frappe/email/doctype/email_account/email_account.js b/frappe/email/doctype/email_account/email_account.js
index d8e0f57506..a36976d3a8 100644
--- a/frappe/email/doctype/email_account/email_account.js
+++ b/frappe/email/doctype/email_account/email_account.js
@@ -115,7 +115,25 @@ function set_default_max_attachment_size(frm) {
 		});
 	}
 }
-
+function add_helpful_links(frm) {
+	// For better UX
+	switch (frm.doc.service) {
+		case "GMail":
+			frm.set_df_property(
+				"password",
+				"description",
+				'To generate password visit <a href="https://knowledge.workspace.google.com/kb/how-to-create-app-passwords-000009237"> here'
+			);
+			break;
+		case "Frappe Mail":
+			frm.set_df_property(
+				"api_secret",
+				"description",
+				'To know more visit <a href="https://github.com/frappe/mail"> here'
+			);
+			break;
+	}
+}
 frappe.ui.form.on("Email Account", {
 	service: function (frm) {
 		$.each(frappe.email_defaults[frm.doc.service], function (key, value) {
@@ -126,22 +144,7 @@ frappe.ui.form.on("Email Account", {
 				frm.set_value(key, value);
 			});
 		}
-		// For better UX
-		if (frm.doc.service == "GMail") {
-			console.log("hello");
-			frm.set_df_property(
-				"password",
-				"description",
-				'To generate password visit <a href="https://knowledge.workspace.google.com/kb/how-to-create-app-passwords-000009237"> here'
-			);
-		}
-		if (frm.doc.service == "Frappe Mail") {
-			frm.set_df_property(
-				"api_secret",
-				"description",
-				'To know more visit <a href="https://github.com/frappe/mail"> here'
-			);
-		}
+		add_helpful_links(frm);
 	},
 
 	use_imap: function (frm) {