fix(Data Import): don't rely on permission for Data Import Log (#26228)

This commit is contained in:
Raffael Meyer 2024-04-30 14:30:24 +02:00 committed by GitHub
parent c1e8d8e791
commit 774f5cc1c6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 18 additions and 10 deletions

View file

@ -404,15 +404,9 @@ frappe.ui.form.on("Data Import", {
render_import_log(frm) {
frappe.call({
method: "frappe.client.get_list",
method: "frappe.core.doctype.data_import.data_import.get_import_logs",
args: {
doctype: "Data Import Log",
filters: {
data_import: frm.doc.name,
},
fields: ["success", "docname", "messages", "exception", "row_indexes"],
limit_page_length: 5000,
order_by: "log_index",
data_import: frm.doc.name,
},
callback: function (r) {
let logs = r.message;

View file

@ -218,6 +218,20 @@ def get_import_status(data_import_name):
return import_status
@frappe.whitelist()
def get_import_logs(data_import: str):
doc = frappe.get_doc("Data Import", data_import)
doc.check_permission("read")
return frappe.get_all(
"Data Import Log",
fields=["success", "docname", "messages", "exception", "row_indexes"],
filters={"data_import": data_import},
limit_page_length=5000,
order_by="log_index",
)
def import_file(doctype, file_path, import_type, submit_after_import=False, console=False):
"""
Import documents in from CSV or XLSX using data import.

View file

@ -58,9 +58,8 @@
}
],
"in_create": 1,
"index_web_pages_for_search": 1,
"links": [],
"modified": "2024-03-23 16:02:17.334396",
"modified": "2024-04-29 18:44:17.050909",
"modified_by": "Administrator",
"module": "Core",
"name": "Data Import Log",
@ -79,6 +78,7 @@
"write": 1
}
],
"read_only": 1,
"sort_field": "creation",
"sort_order": "DESC",
"states": []