refactor: Moved raw queries to frappe orm

This commit is contained in:
Aradhya-Tripathi 2021-07-21 23:29:50 +05:30
parent dd2648b141
commit 79ccaa95f3
2 changed files with 21 additions and 9 deletions

View file

@ -323,12 +323,18 @@ class PersonalDataDeletionRequest(Document):
def remove_unverified_record():
frappe.db.sql(
"""
DELETE FROM `tabPersonal Data Deletion Request`
WHERE `status` = 'Pending Verification'
AND `creation` < (NOW() - INTERVAL '7' DAY)"""
)
frappe.db.delete("Personal Data Deletion Request", {
"status": "Pending Verification",
"creation": ("<", ["Now()", "-", "INTERVAL 7 DAY"])
})
# frappe.db.sql(
# """
# DELETE FROM `tabPersonal Data Deletion Request`
# WHERE `status` = 'Pending Verification'
# AND `creation` < (NOW() - INTERVAL '7' DAY)"""
# )
@frappe.whitelist(allow_guest=True)

View file

@ -133,9 +133,15 @@ def return_link_expired_page(doc, doc_workflow_state):
def clear_old_workflow_actions(doc, user=None):
user = user if user else frappe.session.user
frappe.db.sql("""DELETE FROM `tabWorkflow Action`
WHERE `reference_doctype`=%s AND `reference_name`=%s AND `user`!=%s AND `status`='Open'""",
(doc.get('doctype'), doc.get('name'), user))
frappe.db.delete("Workflow Action", {
"reference_doctype": doc.get("doctype"),
"reference_name": doc.get("name"),
"user": ("!=", user),
"status": "Open"
})
# frappe.db.sql("""DELETE FROM `tabWorkflow Action`
# WHERE `reference_doctype`=%s AND `reference_name`=%s AND `user`!=%s AND `status`='Open'""",
# (doc.get('doctype'), doc.get('name'), user))
def update_completed_workflow_actions(doc, user=None):
user = user if user else frappe.session.user