vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: relocated get_doctype_roles function

Browse source
This commit is contained in:
shariquerik 2021-03-24 16:41:01 +05:30
parent af810e8b6c
commit 7aa0628731
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/__init__.py
View file

@ -466,11 +466,6 @@ def get_roles(username=None):
import frappe.permissions
return frappe.permissions.get_roles(username or local.session.user)
def get_doctype_roles(doctype, access_type="read"):
"""Returns a list of roles that are allowed to access passed doctype."""
meta = get_meta(doctype)
return [d.role for d in meta.get("permissions") if d.get(access_type)]
def get_request_header(key, default=None):
"""Return HTTP request header.

4
frappe/desk/doctype/todo/todo.py
View file

@ -92,7 +92,7 @@ def on_doctype_update():
def get_permission_query_conditions(user):
if not user: user = frappe.session.user
todo_roles = frappe.get_doctype_roles('ToDo')
todo_roles = frappe.permissions.get_doctype_roles('ToDo')
if 'All' in todo_roles:
todo_roles.remove('All')
@ -104,7 +104,7 @@ def get_permission_query_conditions(user):
def has_permission(doc, ptype="read", user=None):
user = user or frappe.session.user
todo_roles = frappe.get_doctype_roles('ToDo', ptype)
todo_roles = frappe.permissions.get_doctype_roles('ToDo', ptype)
if 'All' in todo_roles:
todo_roles.remove('All')

5
frappe/permissions.py
View file

@ -362,6 +362,11 @@ def get_roles(user=None, with_standard=True):
return roles
def get_doctype_roles(doctype, access_type="read"):
"""Returns a list of roles that are allowed to access passed doctype."""
meta = frappe.get_meta(doctype)
return [d.role for d in meta.get("permissions") if d.get(access_type)]
def get_perms_for(roles, perm_doctype='DocPerm'):
'''Get perms for given roles'''
filters = {