From 7b69497841be6dfc7553a28e793ca678b31d68e2 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Mon, 7 Feb 2022 16:25:17 +0530
Subject: [PATCH] fix: Add setting "allow_older_web_view_links" in System
 Settings

---
 .../doctype/system_settings/system_settings.json     | 12 +++++++++---
 frappe/www/printview.py                              |  2 +-
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/frappe/core/doctype/system_settings/system_settings.json b/frappe/core/doctype/system_settings/system_settings.json
index ec5858dfb6..0fad42b3af 100644
--- a/frappe/core/doctype/system_settings/system_settings.json
+++ b/frappe/core/doctype/system_settings/system_settings.json
@@ -2,7 +2,6 @@
  "actions": [],
  "creation": "2022-01-06 03:18:16.326761",
  "doctype": "DocType",
- "document_share_key_expiry": 90,
  "document_type": "System",
  "engine": "InnoDB",
  "field_order": [
@@ -43,6 +42,7 @@
   "allow_login_using_user_name",
   "allow_error_traceback",
   "strip_exif_metadata_from_uploaded_images",
+  "allow_older_web_view_links",
   "password_settings",
   "logout_on_password_reset",
   "force_user_to_reset_password",
@@ -490,16 +490,22 @@
   },
   {
    "default": "90",
-   "description": "Set number of days after which a Document Share Key will be expired",
+   "description": "Number of days after which the shared document link will be expired",
    "fieldname": "document_share_key_expiry",
    "fieldtype": "Int",
    "label": "Document Share Key Expiry (in Days)"
+  },
+  {
+   "default": "1",
+   "fieldname": "allow_older_web_view_links",
+   "fieldtype": "Check",
+   "label": "Allow Older Web View Links (Insecure)"
   }
  ],
  "icon": "fa fa-cog",
  "issingle": 1,
  "links": [],
- "modified": "2022-02-07 03:07:20.782827",
+ "modified": "2022-02-07 03:36:17.319666",
  "modified_by": "Administrator",
  "module": "Core",
  "name": "System Settings",
diff --git a/frappe/www/printview.py b/frappe/www/printview.py
index afd38000bc..dabeb1462b 100644
--- a/frappe/www/printview.py
+++ b/frappe/www/printview.py
@@ -263,7 +263,7 @@ def validate_key(key, doc):
 			return
 
 	# TODO: Deprecate this! kept it for backward compatibility
-	if key == doc.get_signature():
+	if frappe.get_system_settings("allow_older_web_view_links") and key == doc.get_signature():
 		return
 
 	raise frappe.exceptions.InvalidKey