From eae66bdb22f756dc3d0c947d2983b74475eba266 Mon Sep 17 00:00:00 2001 From: Harsh Patel Date: Thu, 15 Feb 2018 15:24:31 +0530 Subject: [PATCH 1/4] Remove tags with spaces (#5015) --- frappe/public/js/frappe/ui/tags.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/ui/tags.js b/frappe/public/js/frappe/ui/tags.js index e520d56978..8d44b7f3ee 100644 --- a/frappe/public/js/frappe/ui/tags.js +++ b/frappe/public/js/frappe/ui/tags.js @@ -106,14 +106,14 @@ frappe.ui.Tags = class { } getTag(label) { - let $tag = $(`
+ let $tag = $(`
`); From 67e589a792df2e551ecdfae575b4136a9372493e Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Thu, 15 Feb 2018 15:29:11 +0530 Subject: [PATCH 2/4] [Fix] Not able to pull items from opportunity in RFQ (#5006) --- frappe/public/js/frappe/form/multi_select_dialog.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/form/multi_select_dialog.js b/frappe/public/js/frappe/form/multi_select_dialog.js index 1cdb7922af..609cd8be80 100644 --- a/frappe/public/js/frappe/form/multi_select_dialog.js +++ b/frappe/public/js/frappe/form/multi_select_dialog.js @@ -192,7 +192,7 @@ frappe.ui.form.MultiSelectDialog = Class.extend({ get_results: function() { let me = this; - let filters = this.get_query().filters; + let filters = this.get_query ? this.get_query().filters : {}; Object.keys(this.setters).forEach(function(setter) { filters[setter] = me.dialog.fields_dict[setter].get_value() || undefined; me.args[setter] = filters[setter]; @@ -209,7 +209,7 @@ frappe.ui.form.MultiSelectDialog = Class.extend({ filters: filters, filter_fields: Object.keys(me.setters).concat([me.date_field]), page_length: this.page_length + 1, - query: this.get_query().query, + query: this.get_query ? this.get_query().query : '', as_dict: 1 } frappe.call({ From e540fd26da18b39c584e3f4abe4dd1879c27a6bc Mon Sep 17 00:00:00 2001 From: Saurabh Date: Thu, 15 Feb 2018 22:37:52 +0530 Subject: [PATCH 3/4] [fix] remove ifnull from get_max_email_uid fields --- frappe/email/doctype/email_account/email_account.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/email/doctype/email_account/email_account.py b/frappe/email/doctype/email_account/email_account.py index 1350d132df..21daaa3022 100755 --- a/frappe/email/doctype/email_account/email_account.py +++ b/frappe/email/doctype/email_account/email_account.py @@ -714,10 +714,10 @@ def get_max_email_uid(email_account): "communication_medium": "Email", "sent_or_received": "Received", "email_account": email_account - }, fields=["ifnull(max(uid), 0) as uid"]) + }, fields=["max(uid) as uid"]) if not result: return 1 else: - max_uid = int(result[0].get("uid", 0)) + 1 + max_uid = cint(result[0].get("uid", 0)) + 1 return max_uid From fae73e9cda55a48a32488772a63e0c23b7af6c27 Mon Sep 17 00:00:00 2001 From: Saurabh Date: Thu, 15 Feb 2018 23:50:57 +0600 Subject: [PATCH 4/4] bumped to version 10.0.25 --- frappe/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index 1dbff97f1b..4d26aac91f 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -14,7 +14,7 @@ import os, sys, importlib, inspect, json from .exceptions import * from .utils.jinja import get_jenv, get_template, render_template, get_email_from_template -__version__ = '10.0.24' +__version__ = '10.0.25' __title__ = "Frappe Framework" local = Local()