vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test: reduce noise in test output (#28862)

Browse source 
* chore: remove verbose output from test runner

This is same output that's shared by test runner in different format?

This makes it annoying to scroll through when just running single test
locally.

* fix: Remove clutter from test output

Test records don't change after first run.
Tests are executed many many times locally

* test: retry flaky postgres backup tests
This commit is contained in:
Ankush Menat 2024-12-23 11:41:47 +05:30 • committed by GitHub
parent dd8b353caa
commit 7d4d6b59df
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
frappe/commands/testing.py
View file

@ -97,7 +97,7 @@ def main(
for handler in testing_module_logger.handlers:
if file := getattr(handler, "baseFilename", None):
click.secho(
f"Detailed logs{' (augment with --verbose)' if not verbose else ''}: {click.style(file, bold=True)}"
f"View detailed logs{' (using --verbose)' if not verbose else ''}: {click.style(file, bold=True)}"
)
test_config = TestConfig(
@ -142,38 +142,6 @@ def main(
results.append([app, category, runner.run(suite)])
success = all(r.wasSuccessful() for _, _, r in results)
click.secho("\nTest Results:", fg="cyan", bold=True)
def _print_result(app, category, result):
tests_run = result.testsRun
failures = len(result.failures)
errors = len(result.errors)
click.echo(
f"\n{click.style(f'{category} Tests in {app}:', bold=True)}\n"
f" Ran: {click.style(f'{tests_run:<3}', fg='cyan')}"
f" Failures: {click.style(f'{failures:<3}', fg='red' if failures else 'green')}"
f" Errors: {click.style(f'{errors:<3}', fg='red' if errors else 'green')}"
)
if failures > 0:
click.echo(f"\n{click.style(category + ' Test Failures:', fg='red', bold=True)}")
for i, failure in enumerate(result.failures, 1):
click.echo(f" {i}. {click.style(str(failure[0]), fg='yellow')}")
if errors > 0:
click.echo(f"\n{click.style(category + ' Test Errors:', fg='red', bold=True)}")
for i, error in enumerate(result.errors, 1):
click.echo(f" {i}. {click.style(str(error[0]), fg='yellow')}")
click.echo(click.style(" " + str(error[1]).split("\n")[-2], fg="red"))
for app, category, result in results:
_print_result(frappe.unscrub(app or "Unspecified App"), frappe.unscrub(category), result)
if success:
click.echo(f"\n{click.style('All tests passed successfully!', fg='green', bold=True)}")
else:
click.echo(f"\n{click.style('Some tests failed or encountered errors.', fg='red', bold=True)}")
if not success:
sys.exit(1)

1
frappe/tests/test_commands.py
View file

@ -637,6 +637,7 @@ class TestBackups(BaseTestCommands):
except OSError:
pass
@run_only_if(db_type_is.MARIADB)
def test_backup_no_options(self):
"""Take a backup without any options"""
before_backup = fetch_latest_backups(partial=True)

6
frappe/tests/utils/generators.py
View file

@ -169,7 +169,7 @@ def _generate_records_for(
# to completely bypass the standard loading and create test records
# according to custom logic.
if hasattr(test_module, "_make_test_records"):
logger.warning("↺" + logstr)
logger.info("↺" + logstr)
testing_logger.info(
f" Made + {index_doctype:<30} via {initial_doctype} through {test_module._make_test_records}"
)
@ -189,12 +189,12 @@ def _generate_records_for(
test_records = load_test_records_for(index_doctype)
if not test_records:
logger.warning("➛ " + logstr + " (missing)")
logger.info("➛ " + logstr + " (missing)")
frappe.local.test_objects[index_doctype] = [] # avoid noisy retries on multiple invocations
print_mandatory_fields(index_doctype, initial_doctype)
return
logger.warning("↺ " + logstr)
logger.info("↺ " + logstr)
testing_logger.info(f" Synced + {index_doctype:<30} via {initial_doctype}")
yield from _sync_records(index_doctype, test_records, reset=reset, commit=commit)