vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: removed TODO marks

Browse source
This commit is contained in:
Philipp Gruener 2024-07-08 15:16:51 +02:00
parent c19e844516
commit 7df4185f87
2 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/__init__.py
View file

@ -448,10 +448,6 @@ def get_site_config(sites_path: str | None = None, site_path: str | None = None)
# read password
config["db_password"] = os.environ.get("FRAPPE_DB_PASSWORD") or config.get("db_password")
# TODO: possible after pg schema isluation fixes (PR 27000)
# if config["db_type"] == "postgres":
# config["db_schema"] = os.environ.get("FRAPPE_DB_PG_SCHEMA") or config.get("db_schema")
# Allow externally extending the config with hooks
if extra_config := config.get("extra_config"):
if isinstance(extra_config, str):

12
frappe/tests/test_db.py
View file

@ -1160,18 +1160,6 @@ class TestDbConnectWithEnvCredentials(FrappeTestCase):
self.assertTrue(re.search("(port 1111 failed|Errno 111)", str(cm.exception)))
# TODO: possible after pg schema isluation fixes (PR 27000)
# # with wrong postgres schema
# with set_env_variable("FRAPPE_DB_PG_SCHEMA", "pg_schema"):
# frappe.init(self.current_site, force=True)
# frappe.connect()
# if frappe.conf.get("db_type") == db_type_is.POSTGRES.value:
# self.assertEqual(frappe.conf.get("db_schema"), "pg_schema")
# else:
# # for mariadb this env should not have any effect
# self.assertIsNone(frappe.conf.get("db_schema"))
# now with configured settings without any influences from env
# finally connect should work without any error (when no wrong credentials are given via ENV)
frappe.init(self.current_site, force=True)