From dbc144595cee4c3367f00dad1e64324d1ea00aab Mon Sep 17 00:00:00 2001
From: barredterra <14891507+barredterra@users.noreply.github.com>
Date: Tue, 9 Dec 2025 14:37:07 +0100
Subject: [PATCH 1/2] fix: link filters UX
---
frappe/public/js/frappe/form/controls/link.js | 8 ++++++--
frappe/public/scss/common/awesomeplete.scss | 3 +++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/frappe/public/js/frappe/form/controls/link.js b/frappe/public/js/frappe/form/controls/link.js
index 778f286bc6..406d3d952e 100644
--- a/frappe/public/js/frappe/form/controls/link.js
+++ b/frappe/public/js/frappe/form/controls/link.js
@@ -315,6 +315,11 @@ frappe.ui.form.ControlLink = class ControlLink extends frappe.ui.form.ControlDat
return false;
}
+ if (item.value === "filter_description__link_option") {
+ e.preventDefault();
+ return false;
+ }
+
if (item.action) {
item.value = "";
item.label = "";
@@ -384,8 +389,7 @@ frappe.ui.form.ControlLink = class ControlLink extends frappe.ui.form.ControlDat
if (filter_string) {
r.message.push({
html: `${filter_string}`,
- value: "",
- action: () => {},
+ value: "filter_description__link_option",
});
}
diff --git a/frappe/public/scss/common/awesomeplete.scss b/frappe/public/scss/common/awesomeplete.scss
index 5cbc1b4863..23a28e2c48 100644
--- a/frappe/public/scss/common/awesomeplete.scss
+++ b/frappe/public/scss/common/awesomeplete.scss
@@ -37,6 +37,9 @@
& > li,
& > [role="option"] {
+ &:has(p[title="filter_description__link_option"]) {
+ cursor: default;
+ }
cursor: pointer;
@include get_textstyle("sm", "regular");
padding: var(--padding-sm);
From e86636a6228cb94f1a86986bec1daa65d93805a5 Mon Sep 17 00:00:00 2001
From: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Date: Wed, 10 Dec 2025 15:36:35 +0100
Subject: [PATCH 2/2] fix: re-add action
---
frappe/public/js/frappe/form/controls/link.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/frappe/public/js/frappe/form/controls/link.js b/frappe/public/js/frappe/form/controls/link.js
index 406d3d952e..fd909fd8c5 100644
--- a/frappe/public/js/frappe/form/controls/link.js
+++ b/frappe/public/js/frappe/form/controls/link.js
@@ -390,6 +390,7 @@ frappe.ui.form.ControlLink = class ControlLink extends frappe.ui.form.ControlDat
r.message.push({
html: `${filter_string}`,
value: "filter_description__link_option",
+ action: () => {},
});
}