vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Remove extra call for review points of form load

Browse source
This commit is contained in:
Suraj Shetty 2019-04-22 22:33:59 +05:30
parent 09f5102884
commit 7ed02cd103
2 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
frappe/boot.py
View file

@ -18,6 +18,7 @@ from frappe.translate import get_lang_dict
from frappe.email.inbox import get_email_accounts
from frappe.core.doctype.feedback_trigger.feedback_trigger import get_enabled_feedback_trigger
from frappe.social.doctype.energy_point_settings.energy_point_settings import is_energy_point_enabled
from frappe.social.doctype.energy_point_log.energy_point_log import get_energy_points
def get_bootinfo():
"""build and return boot info"""
@ -80,6 +81,7 @@ def get_bootinfo():
bootinfo.success_action = get_success_action()
bootinfo.update(get_email_accounts(user=frappe.session.user))
bootinfo.energy_points_enabled = is_energy_point_enabled()
bootinfo.points = get_energy_points(frappe.session.user)
return bootinfo

14
frappe/public/js/frappe/form/review.js
View file

@ -7,17 +7,16 @@ frappe.ui.form.Review = class Review {
constructor({parent, frm}) {
this.parent = parent;
this.frm = frm;
this.fetch_energy_points()
.then(() => {
this.make_review_container();
this.add_review_button();
this.update_reviewers();
});
this.points = frappe.boot.points;
this.make_review_container();
this.add_review_button();
this.update_reviewers();
}
fetch_energy_points() {
update_points() {
return frappe.xcall('frappe.social.doctype.energy_point_log.energy_point_log.get_energy_points', {
user: frappe.session.user
}).then(data => {
frappe.boot.points = data;
this.points = data;
});
}
@ -133,6 +132,7 @@ frappe.ui.form.Review = class Review {
this.frm.get_docinfo().energy_point_logs.unshift(review);
this.frm.timeline.refresh();
this.update_reviewers();
this.update_points();
}).finally(() => {
review_dialog.enable_primary_action();
});