vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Set doc title name as fallback

Browse source 
When the title field is unset for a document, it's value gets unset in a
link field on click. Added this fallback on the endpoint so that
clicking on field doesn't add an additional API call to fetch the title
via Desk.

Co-authored-by: Marica Dsouza <maricadsouza221197@gmail.com>
This commit is contained in:
Gavin D'souza 2024-08-29 20:07:31 +02:00
parent cad512e5a0
commit 7f7c97d499
No known key found for this signature in database
GPG key ID: 5413A43FBD450A34
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/desk/form/load.py
View file

@ -421,7 +421,7 @@ def get_title_values_for_link_and_dynamic_link_fields(doc, link_fields=None):
link_fields = meta.get_link_fields() + meta.get_dynamic_link_fields()
for field in link_fields:
if not doc.get(field.fieldname):
if not (doc_fieldvalue := doc.get(field.fieldname)):
continue
doctype = field.options if field.fieldtype == "Link" else doc.get(field.options)
@ -430,10 +430,8 @@ def get_title_values_for_link_and_dynamic_link_fields(doc, link_fields=None):
if not meta or not meta.title_field or not meta.show_title_field_in_link:
continue
link_title = frappe.db.get_value(
doctype, doc.get(field.fieldname), meta.title_field, cache=True, order_by=None
)
link_titles.update({doctype + "::" + doc.get(field.fieldname): link_title})
link_title = frappe.db.get_value(doctype, doc_fieldvalue, meta.title_field, cache=True, order_by=None)
link_titles.update({doctype + "::" + doc_fieldvalue: link_title or doc_fieldvalue})
return link_titles