vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: enhance delete_custom_fields function to support bypassing hooks

Browse source
This commit is contained in:
Abdeali Chharchhoda 2026-04-23 10:38:54 +05:30
parent a0240a3d18
commit 7fd4451e96
1 changed files with 27 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
frappe/custom/doctype/custom_field/custom_field.py
View file

@ -445,39 +445,20 @@ def _update_fieldname_references(field: CustomField, old_fieldname: str, new_fie
)
def delete_custom_fields(custom_fields: dict):
def delete_custom_fields(custom_fields: dict, bypass_hooks: bool = False):
"""
Delete custom fields from the given doctypes.
Delete custom fields from doctypes.
:param custom_fields: Dictionary of doctypes with fields to be deleted.
:param custom_fields: Dict mapping doctype to field names.
:param bypass_hooks: If `True`, fast raw delete (skips hooks (doc events like on_trash)).
---
Structure of the `custom_fields` dictionary:
Example:
```py
# first structure
{
"DocType1": ["field1", "field2", ...],
"DocType2": ["field1", "field2", ...],
...
}
# second structure
{
"DocType1": [
{"fieldname": "field1", ...},
{"fieldname": "field2", ...},
...
],
"DocType2": [
{"fieldname": "field1", ...},
{"fieldname": "field2", ...},
...
],
...
}
```
delete_custom_fields({"Address": ["custom_a", "custom_b"]})
delete_custom_fields({"ToDo": [{"fieldname": "cf_1"}]}, bypass_hooks=True)
````
"""
for doctype, fields in custom_fields.items():
fieldnames = []
@ -492,12 +473,24 @@ def delete_custom_fields(custom_fields: dict):
if not fieldnames:
continue
frappe.db.delete(
"Custom Field",
{
"fieldname": ("in", set(fieldnames)),
"dt": doctype,
},
)
fieldnames = tuple(set(fieldnames))
if bypass_hooks:
frappe.db.delete(
"Custom Field",
{
"fieldname": ("in", fieldnames),
"dt": doctype,
},
)
else:
custom_field_names = frappe.get_all(
"Custom Field",
filters={"fieldname": ("in", fieldnames), "dt": doctype},
pluck="name",
)
for custom_field_name in custom_field_names:
frappe.get_doc("Custom Field", custom_field_name).delete(ignore_permissions=True, force=True)
frappe.clear_cache(doctype=doctype)