From 7412e079d948b59cdbacce6559d6685fc2eca9d0 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Fri, 18 Jul 2014 11:06:09 +0530 Subject: [PATCH 1/2] Error Reporting: Box for additional info, also send Route --- frappe/public/js/frappe/request.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/frappe/public/js/frappe/request.js b/frappe/public/js/frappe/request.js index a848e44124..abd75c83ac 100644 --- a/frappe/public/js/frappe/request.js +++ b/frappe/public/js/frappe/request.js @@ -254,6 +254,13 @@ frappe.request.report_error = function(xhr, request_opts) { .toggle(error_report_email ? true : false) .on("click", function() { var error_report_message = [ + '
Please type some additional information that could help us reproduce this issue:
', + '
', + '
', + '
Route
', + '
' + frappe.get_route_str() + '
', + '
', '
Error Report
', '
' + exc + '
', '
', From 49b4f7d9b0f58633112be72c00676b782e815597 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Fri, 18 Jul 2014 11:06:24 +0530 Subject: [PATCH 2/2] Correct way to throw error in frappe.throw --- frappe/public/js/frappe/ui/messages.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/ui/messages.js b/frappe/public/js/frappe/ui/messages.js index 88e1b712ff..b9ea89d7e9 100644 --- a/frappe/public/js/frappe/ui/messages.js +++ b/frappe/public/js/frappe/ui/messages.js @@ -17,7 +17,7 @@ frappe.messages.waiting = function(parent, msg, bar_percent) { frappe.throw = function(msg) { msgprint(msg); - throw msg; + throw new Error(msg); } frappe.confirm = function(message, ifyes, ifno) {