From 80ceb33c01ae6d6dd34a23fcafb0dd470ba06bfd Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Wed, 4 Jan 2023 19:20:36 +0530 Subject: [PATCH] fix: allow using login_with_email_link if user_pass_login is disabled unrelated fix --- frappe/core/doctype/system_settings/system_settings.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/frappe/core/doctype/system_settings/system_settings.py b/frappe/core/doctype/system_settings/system_settings.py index 0f7a7f0819..c4f35f3cc0 100644 --- a/frappe/core/doctype/system_settings/system_settings.py +++ b/frappe/core/doctype/system_settings/system_settings.py @@ -50,11 +50,14 @@ class SystemSettings(Document): social_login_enabled = frappe.db.exists("Social Login Key", {"enable_social_login": 1}) ldap_enabled = frappe.db.get_single_value("LDAP Settings", "enabled") + login_with_email_link_enabled = frappe.db.get_single_value( + "System Settings", "login_with_email_link" + ) - if not (social_login_enabled or ldap_enabled): + if not (social_login_enabled or ldap_enabled or login_with_email_link_enabled): frappe.throw( _( - "Please enable atleast one Social Login Key or LDAP before disabling username/password based login." + "Please enable atleast one Social Login Key or LDAP or Login With Email Link before disabling username/password based login." ) )