From 81fa64d4bc10512f01e15208f246d6c23685c012 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Wed, 22 May 2019 16:53:28 +0530 Subject: [PATCH] refactor(form.js): remove very old API --- .../doctype/customize_form/customize_form.js | 102 --- frappe/model/document.py | 2 +- frappe/public/build.json | 123 +--- frappe/public/js/frappe/chat.js | 2 +- frappe/public/js/frappe/dom.js | 87 --- .../js/frappe/form/controls/base_control.js | 10 - .../public/js/frappe/form/controls/control.js | 50 ++ frappe/public/js/frappe/form/footer/footer.js | 2 + frappe/public/js/frappe/form/form.js | 26 +- frappe/public/js/frappe/form/layout.js | 1 - frappe/public/js/frappe/form/linked_with.js | 1 - frappe/public/js/frappe/form/print.js | 79 +- frappe/public/js/frappe/form/save.js | 2 +- .../form/script_helpers.js} | 0 .../form/{footer => sidebar}/assign_to.js | 2 +- .../form/{footer => sidebar}/attachments.js | 2 +- .../form/{ => sidebar}/document_follow.js | 0 .../frappe/form/{ => sidebar}/form_sidebar.js | 11 +- .../frappe/form/{ => sidebar}/form_viewers.js | 2 +- .../js/frappe/form/{ => sidebar}/review.js | 2 +- .../js/frappe/form/{ => sidebar}/share.js | 2 +- .../frappe/form/{ => sidebar}/user_image.js | 0 .../{footer => templates}/attachment.html | 0 .../form/templates/form_document_flow.html | 12 - .../{footer => templates}/form_footer.html | 0 .../form/{footer => templates}/timeline.html | 0 .../{footer => templates}/timeline_item.html | 0 frappe/public/js/frappe/form/toolbar.js | 2 +- frappe/public/js/frappe/misc/tools.js | 152 ---- frappe/public/js/frappe/provide.js | 24 +- .../{misc => utils}/address_and_contact.js | 0 .../js/frappe/{misc => utils}/common.js | 0 .../js/{legacy => frappe/utils}/datatype.js | 52 +- .../js/frappe/{misc => utils}/datetime.js | 0 .../frappe/{misc => utils}/display_image.js | 0 .../{misc => utils}/energy_point_utils.js | 0 .../js/frappe/{misc => utils}/file_manager.js | 0 .../public/js/frappe/{misc => utils}/help.js | 0 .../js/frappe/{misc => utils}/help_links.js | 0 .../public/js/frappe/utils/jquery_plugins.js | 39 + .../frappe/{misc => utils}/number_format.js | 22 +- .../js/frappe/{misc => utils}/pretty_date.js | 0 .../frappe/{misc => utils}/preview_email.js | 0 .../frappe/{misc => utils}/rating_icons.html | 0 .../js/frappe/{misc => utils}/ratings.html | 0 .../js/frappe/{misc => utils}/test_utils.js | 0 frappe/public/js/frappe/utils/tools.js | 76 ++ frappe/public/js/frappe/utils/urllib.js | 80 ++ .../public/js/frappe/{misc => utils}/user.js | 0 .../public/js/frappe/{misc => utils}/utils.js | 0 frappe/public/js/legacy/dom.js | 168 ----- frappe/public/js/legacy/globals.js | 38 - frappe/public/js/legacy/handler.js | 73 -- frappe/public/js/legacy/layout.js | 143 ---- frappe/public/js/legacy/print_format.js | 691 ------------------ frappe/public/js/legacy/print_table.js | 208 ------ frappe/public/js/lib/microtemplate.js | 6 +- frappe/sessions.py | 3 +- frappe/utils/csvutils.py | 4 + 59 files changed, 391 insertions(+), 1910 deletions(-) create mode 100644 frappe/public/js/frappe/form/controls/control.js rename frappe/public/js/{legacy/client_script_helpers.js => frappe/form/script_helpers.js} (100%) rename frappe/public/js/frappe/form/{footer => sidebar}/assign_to.js (99%) rename frappe/public/js/frappe/form/{footer => sidebar}/attachments.js (99%) rename frappe/public/js/frappe/form/{ => sidebar}/document_follow.js (100%) rename frappe/public/js/frappe/form/{ => sidebar}/form_sidebar.js (97%) rename frappe/public/js/frappe/form/{ => sidebar}/form_viewers.js (98%) rename frappe/public/js/frappe/form/{ => sidebar}/review.js (99%) rename frappe/public/js/frappe/form/{ => sidebar}/share.js (99%) rename frappe/public/js/frappe/form/{ => sidebar}/user_image.js (100%) rename frappe/public/js/frappe/form/{footer => templates}/attachment.html (100%) delete mode 100644 frappe/public/js/frappe/form/templates/form_document_flow.html rename frappe/public/js/frappe/form/{footer => templates}/form_footer.html (100%) rename frappe/public/js/frappe/form/{footer => templates}/timeline.html (100%) rename frappe/public/js/frappe/form/{footer => templates}/timeline_item.html (100%) delete mode 100644 frappe/public/js/frappe/misc/tools.js rename frappe/public/js/frappe/{misc => utils}/address_and_contact.js (100%) rename frappe/public/js/frappe/{misc => utils}/common.js (100%) rename frappe/public/js/{legacy => frappe/utils}/datatype.js (64%) rename frappe/public/js/frappe/{misc => utils}/datetime.js (100%) rename frappe/public/js/frappe/{misc => utils}/display_image.js (100%) rename frappe/public/js/frappe/{misc => utils}/energy_point_utils.js (100%) rename frappe/public/js/frappe/{misc => utils}/file_manager.js (100%) rename frappe/public/js/frappe/{misc => utils}/help.js (100%) rename frappe/public/js/frappe/{misc => utils}/help_links.js (100%) create mode 100644 frappe/public/js/frappe/utils/jquery_plugins.js rename frappe/public/js/frappe/{misc => utils}/number_format.js (96%) rename frappe/public/js/frappe/{misc => utils}/pretty_date.js (100%) rename frappe/public/js/frappe/{misc => utils}/preview_email.js (100%) rename frappe/public/js/frappe/{misc => utils}/rating_icons.html (100%) rename frappe/public/js/frappe/{misc => utils}/ratings.html (100%) rename frappe/public/js/frappe/{misc => utils}/test_utils.js (100%) create mode 100644 frappe/public/js/frappe/utils/tools.js create mode 100644 frappe/public/js/frappe/utils/urllib.js rename frappe/public/js/frappe/{misc => utils}/user.js (100%) rename frappe/public/js/frappe/{misc => utils}/utils.js (100%) delete mode 100644 frappe/public/js/legacy/dom.js delete mode 100644 frappe/public/js/legacy/globals.js delete mode 100644 frappe/public/js/legacy/handler.js delete mode 100644 frappe/public/js/legacy/layout.js delete mode 100644 frappe/public/js/legacy/print_format.js delete mode 100644 frappe/public/js/legacy/print_table.js diff --git a/frappe/custom/doctype/customize_form/customize_form.js b/frappe/custom/doctype/customize_form/customize_form.js index c503c903eb..f1eadaaf2e 100644 --- a/frappe/custom/doctype/customize_form/customize_form.js +++ b/frappe/custom/doctype/customize_form/customize_form.js @@ -5,8 +5,6 @@ frappe.provide("frappe.customize_form"); frappe.ui.form.on("Customize Form", { onload: function(frm) { - frappe.customize_form.add_fields_help(frm); - frm.set_query("doc_type", function() { return { translate_values: false, @@ -206,103 +204,3 @@ frappe.customize_form.clear_locals_and_refresh = function(frm) { frm.refresh(); } -frappe.customize_form.add_fields_help = function(frm) { - $(frm.grids[0].parent).before( - '
\ - ' + __("Help") + '\ -
'); - $('#fields_help').click(function() { - var d = new frappe.ui.Dialog({ - title: __('Help: Field Properties'), - width: 600 - }); - - var help = - "\ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ - \ -
" + __("Label") + "" + __("Set the display label for the field") + "
" + __("Type") + "" + __("Change type of field. (Currently, Type change is \ - allowed among 'Currency and Float')") + "
" + __("Options") + "" + __("Specify the value of the field") + "
" + __("Perm Level") + "\ - " + __("Assign a permission level to the field.") + "
\ - (" + __("Permissions can be managed via Setup > Role Permissions Manager") + "\ -
" + __("Width") + "\ - " + __("Width of the input box") + "
\ - " + __("Example") + ": 120px\ -
" + __("Reqd") + "" + __("Mark the field as Mandatory") + "
" + __("In Filter") + "" + __("Use the field to filter records") + "
" + __("Hidden") + "" + __("Hide field in form") + "
" + __("Print Hide") + "" + __("Hide field in Standard Print Format") + "
" + __("Report Hide") + "" + __("Hide field in Report Builder") + "
" + __("Allow on Submit") + "" + __("Allow field to remain editable even after submission") + "
" + __("Depends On") + "\ - Show field if a condition is met
\ - Example: eval:doc.status=='Cancelled'\ - on a field like \"reason_for_cancellation\" will reveal \ - \"Reason for Cancellation\" only if the record is Cancelled.\ -
" + __("Description") + "" + __("Show a description below the field") + "
" + __("Default") + "" + __("Specify a default value") + "
" + __("Press Esc to close") + "\ -
" - - $y(d.body, {padding: '32px', textAlign: 'center', lineHeight: '200%'}); - - $a(d.body, 'div', '', {textAlign: 'left'}, help); - - d.show(); - - frappe.customize_form.fields_help_dialog = d; - - }); -} diff --git a/frappe/model/document.py b/frappe/model/document.py index 04c802df6e..ace752a2f8 100644 --- a/frappe/model/document.py +++ b/frappe/model/document.py @@ -1241,7 +1241,7 @@ class Document(BaseDocument): file_lock.delete_lock(self.get_signature()) # validation helpers - def validate_from_to_dates(from_date_field, to_date_field): + def validate_from_to_dates(self, from_date_field, to_date_field): ''' Generic validation to verify date sequence ''' diff --git a/frappe/public/build.json b/frappe/public/build.json index d2c2cd5f42..c100aac718 100755 --- a/frappe/public/build.json +++ b/frappe/public/build.json @@ -30,12 +30,12 @@ "public/js/lib/md5.min.js", "public/js/frappe/provide.js", "public/js/frappe/format.js", - "public/js/frappe/misc/number_format.js", - "public/js/frappe/misc/utils.js", - "public/js/frappe/misc/common.js", + "public/js/frappe/utils/number_format.js", + "public/js/frappe/utils/utils.js", + "public/js/frappe/utils/common.js", "public/js/frappe/ui/messages.js", "public/js/frappe/translate.js", - "public/js/frappe/misc/pretty_date.js", + "public/js/frappe/utils/pretty_date.js", "public/js/lib/microtemplate.js", "public/js/frappe/query_string.js", @@ -48,7 +48,7 @@ "public/js/frappe/model/perm.js", "website/js/website.js", - "public/js/frappe/misc/rating_icons.html", + "public/js/frappe/utils/rating_icons.html", "public/js/frappe/socketio_client.js" ], "js/bootstrap-4-web.min.js": [ @@ -56,45 +56,7 @@ ], "js/control.min.js": [ "public/js/frappe/ui/capture.js", - "public/js/frappe/form/controls/base_control.js", - "public/js/frappe/form/controls/base_input.js", - "public/js/frappe/form/controls/data.js", - "public/js/frappe/form/controls/int.js", - "public/js/frappe/form/controls/float.js", - "public/js/frappe/form/controls/currency.js", - "public/js/frappe/form/controls/date.js", - "public/js/frappe/form/controls/time.js", - "public/js/frappe/form/controls/datetime.js", - "public/js/frappe/form/controls/date_range.js", - "public/js/frappe/form/controls/select.js", - "public/js/frappe/form/controls/link.js", - "public/js/frappe/form/controls/dynamic_link.js", - "public/js/frappe/form/controls/text.js", - "public/js/frappe/form/controls/code.js", - "public/js/frappe/form/controls/text_editor.js", - "public/js/frappe/form/controls/comment.js", - "public/js/frappe/form/controls/check.js", - "public/js/frappe/form/controls/image.js", - "public/js/frappe/form/controls/attach.js", - "public/js/frappe/form/controls/attach_image.js", - "public/js/frappe/form/controls/table.js", - "public/js/frappe/form/controls/color.js", - "public/js/frappe/form/controls/signature.js", - "public/js/frappe/form/controls/password.js", - "public/js/frappe/form/controls/read_only.js", - "public/js/frappe/form/controls/button.js", - "public/js/frappe/form/controls/html.js", - "public/js/frappe/form/controls/markdown_editor.js", - "public/js/frappe/form/controls/html_editor.js", - "public/js/frappe/form/controls/heading.js", - "public/js/frappe/form/controls/autocomplete.js", - "public/js/frappe/form/controls/barcode.js", - "public/js/frappe/form/controls/geolocation.js", - "public/js/frappe/form/controls/multiselect.js", - "public/js/frappe/form/controls/multicheck.js", - "public/js/frappe/form/controls/table_multiselect.js", - "public/js/frappe/form/controls/multiselect_pills.js", - "public/js/frappe/form/controls/rating.js" + "public/js/frappe/form/controls/control.js" ], "js/dialog.min.js": [ "public/js/frappe/dom.js", @@ -177,7 +139,7 @@ "public/js/frappe/request.js", "public/js/frappe/socketio_client.js", - "public/js/frappe/misc/utils.js", + "public/js/frappe/utils/utils.js", "public/js/frappe/event_emitter.js", "public/js/frappe/router.js", "public/js/frappe/router_history.js", @@ -185,9 +147,6 @@ "public/js/frappe/roles_editor.js", "public/js/lib/microtemplate.js", - "public/js/legacy/globals.js", - "public/js/legacy/datatype.js", - "public/js/legacy/dom.js", "public/js/legacy/handler.js", "public/js/frappe/ui/page.html", @@ -214,18 +173,20 @@ "public/js/frappe/model/user_settings.js", "public/js/lib/md5.min.js", - "public/js/frappe/misc/user.js", - "public/js/frappe/misc/common.js", - "public/js/frappe/misc/pretty_date.js", - "public/js/frappe/misc/test_utils.js", - "public/js/frappe/misc/tools.js", - "public/js/frappe/misc/datetime.js", - "public/js/frappe/misc/number_format.js", - "public/js/frappe/misc/help.js", - "public/js/frappe/misc/help_links.js", - "public/js/frappe/misc/address_and_contact.js", - "public/js/frappe/misc/preview_email.js", - "public/js/frappe/misc/file_manager.js", + "public/js/frappe/utils/user.js", + "public/js/frappe/utils/common.js", + "public/js/frappe/utils/urllib.js", + "public/js/frappe/utils/pretty_date.js", + "public/js/frappe/utils/test_utils.js", + "public/js/frappe/utils/tools.js", + "public/js/frappe/utils/jquery_plugins.js", + "public/js/frappe/utils/datetime.js", + "public/js/frappe/utils/number_format.js", + "public/js/frappe/utils/help.js", + "public/js/frappe/utils/help_links.js", + "public/js/frappe/utils/address_and_contact.js", + "public/js/frappe/utils/preview_email.js", + "public/js/frappe/utils/file_manager.js", "public/js/frappe/ui/upload.html", "public/js/frappe/upload.js", @@ -257,11 +218,11 @@ "public/js/frappe/query_string.js", "public/js/frappe/ui/comment.js", - "public/js/frappe/misc/rating_icons.html", + "public/js/frappe/utils/rating_icons.html", "public/js/frappe/chat.js", "public/js/frappe/social/social_factory.js", - "public/js/frappe/misc/energy_point_utils.js" + "public/js/frappe/utils/energy_point_utils.js" ], "css/module.min.css": [ "public/less/module.less" @@ -270,7 +231,6 @@ "public/less/form_grid.less" ], "js/form.min.js": [ - "public/js/frappe/form/document_follow.js", "public/js/frappe/form/templates/print_layout.html", "public/js/frappe/form/templates/users_in_sidebar.html", "public/js/frappe/form/templates/set_sharing.html", @@ -278,31 +238,13 @@ "public/js/frappe/form/templates/form_dashboard.html", "public/js/frappe/form/templates/form_document_flow.html", "public/js/frappe/form/templates/form_links.html", + "public/js/frappe/form/templates/attachment.html", + "public/js/frappe/form/templates/form_footer.html", + "public/js/frappe/form/templates/timeline.html", + "public/js/frappe/form/templates/timeline_item.html", + "public/js/frappe/form/controls/control.js", "public/js/frappe/views/formview.js", - "public/js/legacy/form.js", - "public/js/legacy/client_script_helpers.js", - "public/js/frappe/form/toolbar.js", - "public/js/frappe/form/dashboard.js", - "public/js/frappe/form/save.js", - "public/js/frappe/form/script_manager.js", - "public/js/frappe/form/linked_with.js", - "public/js/frappe/form/workflow.js", - "public/js/frappe/form/print.js", - "public/js/frappe/form/form_sidebar.js", - "public/js/frappe/form/user_image.js", - "public/js/frappe/form/share.js", - "public/js/frappe/form/review.js", - "public/js/frappe/form/form_viewers.js", - "public/js/frappe/form/footer/attachment.html", - "public/js/frappe/form/footer/form_footer.html", - "public/js/frappe/form/footer/timeline.html", - "public/js/frappe/form/footer/timeline_item.html", - "public/js/frappe/form/footer/footer.js", - "public/js/frappe/form/footer/attachments.js", - "public/js/frappe/form/footer/timeline.js", - "public/js/frappe/form/footer/assign_to.js", - "public/js/frappe/form/quick_entry.js", - "public/js/frappe/form/success_action.js", + "public/js/frappe/form/form.js", "public/js/frappe/meta_tag.js" ], "css/list.min.css": [ @@ -369,7 +311,7 @@ "public/js/frappe/ui/group_by/group_by.js" ], "js/web_form.min.js": [ - "public/js/frappe/misc/datetime.js", + "public/js/frappe/utils/datetime.js", "website/js/web_form.js", "public/js/lib/datepicker/datepicker.min.js", "public/js/lib/datepicker/datepicker.en.js" @@ -383,11 +325,6 @@ "public/less/form_grid.less", "public/less/controls.less" ], - "js/print_format_v3.min.js": [ - "public/js/legacy/layout.js", - "public/js/legacy/print_table.js", - "public/js/legacy/print_format.js" - ], "frappe/css/email.css": [ "public/less/email.less" ], diff --git a/frappe/public/js/frappe/chat.js b/frappe/public/js/frappe/chat.js index 533ca90856..9b67a7d834 100644 --- a/frappe/public/js/frappe/chat.js +++ b/frappe/public/js/frappe/chat.js @@ -9,7 +9,7 @@ import './socketio_client' import './ui/dialog' import './ui/capture' -import './misc/user' +import './utils/user' /* eslint semi: "never" */ // Fuck semicolons - https://mislav.net/2010/05/semicolons diff --git a/frappe/public/js/frappe/dom.js b/frappe/public/js/frappe/dom.js index 830ed0a5ce..da03bd29f8 100644 --- a/frappe/public/js/frappe/dom.js +++ b/frappe/public/js/frappe/dom.js @@ -339,90 +339,3 @@ $(window).on('offline', function() { message: __('Connection lost. Some features might not work.') }); }); - - -// add