From 82cb2d0cbbb7941c18871e56119d28a5223d7cb8 Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Mon, 2 Sep 2019 17:33:42 +0530 Subject: [PATCH] refactor: improved permission logic --- frappe/handler.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/frappe/handler.py b/frappe/handler.py index 97831fe47a..fa570f334d 100755 --- a/frappe/handler.py +++ b/frappe/handler.py @@ -141,12 +141,13 @@ def uploadfile(): @frappe.whitelist(allow_guest=True) def upload_file(): - ignore_permissions = False - if frappe.session.user == 'Guest' and \ - not frappe.get_system_settings('allow_guests_to_upload_files'): - return + if frappe.session.user == 'Guest': + if frappe.get_system_settings('allow_guests_to_upload_files'): + ignore_permissions = True + else: + return else: - ignore_permissions = True + ignore_permissions = False files = frappe.request.files is_private = frappe.form_dict.is_private