vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: remove needless coupling of return values

Browse source
This commit is contained in:
Ankush Menat 2024-02-12 11:14:57 +05:30
parent 16fa5ec9bd
commit 8344bce09a
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frappe/workflow/doctype/workflow_action/workflow_action.py
View file

@ -108,7 +108,8 @@ def process_workflow_actions(doc, state):
if not next_possible_transitions:
return
user_data_map, roles = get_users_next_action_data(next_possible_transitions, doc)
roles = {t.allowed for t in next_possible_transitions}
user_data_map = get_users_next_action_data(next_possible_transitions, doc)
if not user_data_map:
return
@ -327,10 +328,8 @@ def get_next_possible_transitions(workflow_name, state, doc=None):
def get_users_next_action_data(transitions, doc):
roles = set()
user_data_map = {}
for transition in transitions:
roles.add(transition.allowed)
users = get_users_with_role(transition.allowed)
filtered_users = filter_allowed_users(users, doc, transition)
for user in filtered_users:
@ -350,7 +349,7 @@ def get_users_next_action_data(transitions, doc):
}
)
)
return user_data_map, roles
return user_data_map
def create_workflow_actions_for_roles(roles, doc):