From 83f2227cdbe64d5bfd373c0e94ef488801a4eac2 Mon Sep 17 00:00:00 2001
From: Maharshi Patel <39730881+maharshivpatel@users.noreply.github.com>
Date: Wed, 22 Nov 2023 12:31:35 +0530
Subject: [PATCH] fix: review points when added more then once. (#23239)

* fix: review points when added more then once.

previously when user added review more then once it didn't work properly
because of apply_only_once check which is only meant for rule based points
changed that behaviour to only check when called from energy_point_rule by checking if doc.rule is set.
---
 .../doctype/energy_point_log/energy_point_log.py    | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/frappe/social/doctype/energy_point_log/energy_point_log.py b/frappe/social/doctype/energy_point_log/energy_point_log.py
index 07c91396d7..a9b6d01e4e 100644
--- a/frappe/social/doctype/energy_point_log/energy_point_log.py
+++ b/frappe/social/doctype/energy_point_log/energy_point_log.py
@@ -189,13 +189,12 @@ def get_alert_dict(doc):
 
 def create_energy_points_log(ref_doctype, ref_name, doc, apply_only_once=False):
 	doc = frappe._dict(doc)
-
-	log_exists = check_if_log_exists(
-		ref_doctype, ref_name, doc.rule, None if apply_only_once else doc.user
-	)
-
-	if log_exists:
-		return frappe.get_doc("Energy Point Log", log_exists)
+	if doc.rule:
+		log_exists = check_if_log_exists(
+			ref_doctype, ref_name, doc.rule, None if apply_only_once else doc.user
+		)
+		if log_exists:
+			return frappe.get_doc("Energy Point Log", log_exists)
 
 	new_log = frappe.new_doc("Energy Point Log")
 	new_log.reference_doctype = ref_doctype