From 84bee76aba5c449a8cc0347574077d4b867ba486 Mon Sep 17 00:00:00 2001 From: Akhil Narang Date: Tue, 8 Oct 2024 16:52:57 +0530 Subject: [PATCH] fix: ensure that the role exists Some setups can have broken links here, resulting in a KeyError Signed-off-by: Akhil Narang --- .../patches/v16_0/move_role_desk_settings_to_user.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/frappe/patches/v16_0/move_role_desk_settings_to_user.py b/frappe/patches/v16_0/move_role_desk_settings_to_user.py index a33142a23a..2d01d43f43 100644 --- a/frappe/patches/v16_0/move_role_desk_settings_to_user.py +++ b/frappe/patches/v16_0/move_role_desk_settings_to_user.py @@ -11,10 +11,10 @@ def execute(): for user in frappe.get_list("User"): user_desk_settings = {} for role_name in frappe.get_roles(username=user.name): - role = roles[role_name] - for key in desk_properties: - if role.get(key) is None: - role[key] = 1 - user_desk_settings[key] = user_desk_settings.get(key) or role.get(key) + if role := roles.get(role_name): + for key in desk_properties: + if role.get(key) is None: + role[key] = 1 + user_desk_settings[key] = user_desk_settings.get(key) or role.get(key) frappe.db.set_value("User", user.name, user_desk_settings)