From 8550d9be447f317de1827f5086eedf6784cf769b Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Wed, 4 Feb 2015 09:53:52 +0530 Subject: [PATCH] [design] In mobile view, remove input borders and show modals in full screen --- frappe/build.py | 6 +- .../page/desktop/desktop_module_icon.html | 5 +- .../page/applications/application_row.html | 2 +- .../desk/page/applications/applications.css | 10 +- frappe/public/build.json | 4 +- frappe/public/css/desktop.css | 3 +- frappe/public/css/form.css | 5 +- frappe/public/css/form_grid.css | 2 +- frappe/public/css/mobile.css | 93 ++++++++++++-- frappe/public/css/navbar.css | 2 +- frappe/public/js/frappe/dom.js | 6 +- frappe/public/js/frappe/form/control.js | 18 ++- .../js/frappe/form/footer/timeline.html | 16 ++- .../public/js/frappe/form/footer/timeline.js | 21 +++- .../js/frappe/form/footer/timeline_item.html | 8 +- frappe/public/js/frappe/form/grid_form.html | 16 ++- frappe/public/js/frappe/form/layout.js | 2 +- frappe/public/js/frappe/ui/modal.html | 4 +- frappe/public/less/desktop.less | 3 +- frappe/public/less/form.less | 6 +- frappe/public/less/form_grid.less | 2 +- frappe/public/less/mixins.less | 7 +- frappe/public/less/mobile.less | 116 +++++++++++++++++- 23 files changed, 285 insertions(+), 72 deletions(-) diff --git a/frappe/build.py b/frappe/build.py index 2619495d6b..c2e2a8470d 100644 --- a/frappe/build.py +++ b/frappe/build.py @@ -180,6 +180,8 @@ def compile_less(): continue timestamps[fpath] = mtime + print "compiling {0}".format(fpath) - os.system("lessc {0} > {1}".format(fpath, - os.path.join(path, "public", "css", fname.rsplit(".", 1)[0] + ".css"))) + + css_path = os.path.join(path, "public", "css", fname.rsplit(".", 1)[0] + ".css") + os.system("lessc {0} > {1}".format(fpath, css_path)) diff --git a/frappe/core/page/desktop/desktop_module_icon.html b/frappe/core/page/desktop/desktop_module_icon.html index 2d4b318658..4a02d9845f 100644 --- a/frappe/core/page/desktop/desktop_module_icon.html +++ b/frappe/core/page/desktop/desktop_module_icon.html @@ -5,8 +5,7 @@ - - - {%= _label %} + + {%= _label %} diff --git a/frappe/desk/page/applications/application_row.html b/frappe/desk/page/applications/application_row.html index 91fc7494f0..6561ea2034 100644 --- a/frappe/desk/page/applications/application_row.html +++ b/frappe/desk/page/applications/application_row.html @@ -1,6 +1,6 @@
-
+
{% if (app.installed) { %} {% } else { %} diff --git a/frappe/desk/page/applications/applications.css b/frappe/desk/page/applications/applications.css index 50490fb6b6..8621aaaffd 100644 --- a/frappe/desk/page/applications/applications.css +++ b/frappe/desk/page/applications/applications.css @@ -6,11 +6,15 @@ margin-top: 3px; } -#page-applications .app-icon { - width: 70px; - height: 70px; +#page-applications .app-icon-wrapper { + padding-right: 15px; } #page-applications .form-group { margin-bottom: 0px; } + +#page-applications .app-buttons .btn { + width: 84px; + text-align: center; +} diff --git a/frappe/public/build.json b/frappe/public/build.json index 8d06868d2b..d45b773520 100644 --- a/frappe/public/build.json +++ b/frappe/public/build.json @@ -32,7 +32,6 @@ "public/css/font-awesome.css", "public/css/octicons/octicons.css", "public/css/desk.css", - "public/css/mobile.css", "public/css/indicator.css", "public/css/avatar.css", "public/css/navbar.css", @@ -47,7 +46,8 @@ "public/css/tree_grid.css", "public/css/tree.css", "public/css/nprogress.css", - "public/css/desktop.css" + "public/css/desktop.css", + "public/css/mobile.css" ], "js/frappe.min.js": [ "public/js/lib/jquery/jquery-ui.min.js", diff --git a/frappe/public/css/desktop.css b/frappe/public/css/desktop.css index 756596d97f..178e315b75 100644 --- a/frappe/public/css/desktop.css +++ b/frappe/public/css/desktop.css @@ -28,7 +28,7 @@ body[data-route="desktop"] .navbar-default { margin-top: 10px; transition: 0.2s; -webkit-transition: 0.2s; - text-shadow: 0px 1px 2px rgba(0, 0, 0, 0.5); + text-shadow: 0px 1px 2px rgba(0, 0, 0, 0.5), 0px 1px 5px rgba(0, 0, 0, 0.3); } .app-icon { padding: 20px; @@ -51,7 +51,6 @@ body[data-route="desktop"] .navbar-default { .app-icon img { height: 32px; width: 32px; - margin-top: -3px; } .app-icon path { fill: #fafbfc; diff --git a/frappe/public/css/form.css b/frappe/public/css/form.css index 3ef848e480..0f4dd58a28 100644 --- a/frappe/public/css/form.css +++ b/frappe/public/css/form.css @@ -67,6 +67,9 @@ margin-top: 0px; padding: 15px 30px; } +.timeline-item .icon-fixed-width { + text-align: center; +} .timeline-item .reply { margin-top: 5px; } @@ -76,7 +79,7 @@ } .timeline-head { background-color: #fafbfc; - padding: 30px 30px 15px 30px; + padding: 15px 30px; border-bottom: 1px solid #d1d8dd; } .form-footer h5 { diff --git a/frappe/public/css/form_grid.css b/frappe/public/css/form_grid.css index bde7170c9a..da3cb73297 100644 --- a/frappe/public/css/form_grid.css +++ b/frappe/public/css/form_grid.css @@ -75,7 +75,7 @@ -webkit-transition: all 0.2s ease; } .grid-row-open .form-in-grid { - max-height: 1200px; + max-height: 10000px; transform: scale3d(1, 1, 1) translate3d(0, 0, 0); -webkit-transform: scale3d(1, 1, 1) translate3d(0, 0, 0); } diff --git a/frappe/public/css/mobile.css b/frappe/public/css/mobile.css index abff2bd382..7e28d6c437 100644 --- a/frappe/public/css/mobile.css +++ b/frappe/public/css/mobile.css @@ -1,4 +1,26 @@ @media (max-width: 767px) { + .modal .modal-dialog { + margin: 0px; + padding: 0px; + width: 100%; + height: 100%; + position: fixed; + top: 0px; + bottom: 0px; + left: 0px; + right: 0px; + overflow-y: auto; + background-color: #fff; + } + .modal .modal-content { + border-radius: 0px; + border: none; + box-shadow: none; + height: 100%; + } + .modal .modal-body .form-layout { + margin: -15px; + } .layout-main-section-wrapper { padding: 0px; } @@ -17,6 +39,50 @@ border-right: none !important; border-radius: none; } + .form-page .form-section { + padding: 0px 15px; + } + .form-page .frappe-control { + padding: 7px 15px; + border-bottom: 1px solid #d1d8dd; + margin: 0px -15px; + } + .form-page .frappe-control .link-btn { + top: -2px; + } + .form-page .frappe-control .like-disabled-input { + min-height: none !important; + } + .form-page .form-section:last-child .form-column:last-child .frappe-control:last-child { + border-bottom: none; + } + .form-page .form-control { + border: none; + box-shadow: none; + background-color: inherit; + height: auto; + padding: 0px; + margin-bottom: 7px; + border-radius: 0px; + text-align: left !important; + } + .form-page .form-control:focus { + box-shadow: none; + } + .timeline { + border-left: none !important; + border-right: none !important; + } + .timeline .timeline-head { + padding: 7px 15px; + } + .timeline .timeline-item { + padding: 15px; + border-bottom: 1px dashed #d1d8dd; + } + .timeline .timeline-item:last-child { + border-bottom: none; + } .doclist-row { position: relative; padding-right: 10px; @@ -26,7 +92,7 @@ text-align: left; margin-top: 3px; } - .doclist-row .doclist-row.has-checkbox .list-row-id { + .doclist-row.has-checkbox .list-row-id { left: 40px; } .doclist-row .list-row-indicator { @@ -95,6 +161,7 @@ display: inline-block !important; padding-left: 0px; margin-left: 0px; + padding-top: 6px; } body[data-route^="Module"] .navbar .navbar-home:before { font-family: FontAwesome; @@ -105,18 +172,27 @@ *margin-right: .3em; display: inline-block; speak: none; - color: #c0c9d2; font-size: 24px; transition: 0.2s; position: relative; top: 3px; - content: "\f104" !important; - margin-right: 5px !important; + content: "\f104"; + margin-right: 5px; + color: #6c7680; } body[data-route^="Module"] .navbar .navbar-home:hover:before, body[data-route^="Module"] .navbar .navbar-home:focus:before, body[data-route^="Module"] .navbar .navbar-home:active:before { - color: #36414c; + color: #36414c !important; + } + body[data-route^="Module"] .page-title { + width: 100%; + } + body[data-route^="Module"] .page-actions { + display: none !important; + } + .module-item { + padding: 7px 0px !important; } #navbar-breadcrumbs { margin: 0px; @@ -128,8 +204,9 @@ vertical-align: middle; } #navbar-breadcrumbs > li > a:before { - content: "\f104" !important; - margin-right: 5px !important; + content: "\f104"; + margin-right: 5px; + color: #6c7680; } #navbar-breadcrumbs li:not(:nth-last-child(-n+1)) { display: none; @@ -204,7 +281,7 @@ font-size: inherit; position: relative; right: 7px; - top: -21px; + top: -20px; height: 0; } .sidebar form { diff --git a/frappe/public/css/navbar.css b/frappe/public/css/navbar.css index 465c723d27..d007cd77f4 100644 --- a/frappe/public/css/navbar.css +++ b/frappe/public/css/navbar.css @@ -72,13 +72,13 @@ *margin-right: .3em; display: inline-block; speak: none; - color: #c0c9d2; font-size: 24px; transition: 0.2s; position: relative; top: 3px; content: "\f105"; margin-right: 15px; + color: #c0c9d2; } #navbar-breadcrumbs > li > a:hover:before, #navbar-breadcrumbs > li > a:focus:before, diff --git a/frappe/public/js/frappe/dom.js b/frappe/public/js/frappe/dom.js index e904968817..673d5b5199 100644 --- a/frappe/public/js/frappe/dom.js +++ b/frappe/public/js/frappe/dom.js @@ -62,7 +62,7 @@ frappe.dom = { freeze: function() { // blur if(!$('#freeze').length) { - $("