vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test: improve logging during test record creation failure (#28142)

Browse source
This commit is contained in:
David Arnold 2024-10-16 15:07:39 +02:00 • committed by GitHub
parent 9788e47bb0
commit 860ae4fdcb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/tests/utils/generators.py
View file

@ -323,6 +323,7 @@ def _try_create(record, reset=False, commit=False) -> tuple["Document", bool]:
d.docstatus = 0
tolerated_errors = (frappe.NameError, *(d.flags.ignore_these_exceptions_in_test or []))
try:
d.run_method("before_test_insert")
d.insert(ignore_if_duplicate=True)
@ -330,16 +331,10 @@ def _try_create(record, reset=False, commit=False) -> tuple["Document", bool]:
if docstatus == 1:
d.submit()
except frappe.NameError:
except tolerated_errors as e:
logger.warning(f"Error during test record creation for {d.name} ({d.doctype}): {e!s}")
revert_naming(d)
except Exception as e:
if d.flags.ignore_these_exceptions_in_test and e.__class__ in d.flags.ignore_these_exceptions_in_test:
revert_naming(d)
else:
logger.debug(f"Error in making test record for {d.doctype} {d.name}")
raise
if commit:
frappe.db.commit()