vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #33809 from mihir-kandoi/33758

Browse source 
feat: enable non negative validation for Percent type fields
This commit is contained in:
Ejaaz Khan 2025-08-28 15:06:48 +05:30 • committed by GitHub
commit 86c719ec6d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/core/doctype/docfield/docfield.json
View file

@ -499,7 +499,7 @@
},
{
"default": "0",
"depends_on": "eval:in_list([\"Int\", \"Float\", \"Currency\"], doc.fieldtype)",
"depends_on": "eval:in_list([\"Int\", \"Float\", \"Currency\", \"Percent\"], doc.fieldtype)",
"fieldname": "non_negative",
"fieldtype": "Check",
"label": "Non Negative"
@ -609,18 +609,20 @@
"label": "Sticky"
}
],
"grid_page_length": 50,
"idx": 1,
"index_web_pages_for_search": 1,
"istable": 1,
"links": [],
"modified": "2025-01-30 14:58:19.746600",
"modified": "2025-08-26 22:08:20.940308",
"modified_by": "Administrator",
"module": "Core",
"name": "DocField",
"naming_rule": "Random",
"owner": "Administrator",
"permissions": [],
"row_format": "Dynamic",
"sort_field": "creation",
"sort_order": "ASC",
"states": []
}
}

2
frappe/model/document.py
View file

@ -787,7 +787,7 @@ class Document(BaseDocument):
)
for df in self.meta.get(
"fields", {"non_negative": ("=", 1), "fieldtype": ("in", ["Int", "Float", "Currency"])}
"fields", {"non_negative": ("=", 1), "fieldtype": ("in", ["Int", "Float", "Currency", "Percent"])}
):
if flt(self.get(df.fieldname)) < 0:
msg = get_msg(df)