From 86e4a3a6e181f55f0f52507cf5378bc7e4ff00c8 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 1 Nov 2023 15:03:45 +0530 Subject: [PATCH] fix: Respect "Do Not Track" settings Don't offer telemetry as option if DNT is set in browser. https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack --- frappe/desk/page/setup_wizard/setup_wizard.js | 2 +- frappe/public/js/telemetry/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/desk/page/setup_wizard/setup_wizard.js b/frappe/desk/page/setup_wizard/setup_wizard.js index c237624fff..8d42b804cd 100644 --- a/frappe/desk/page/setup_wizard/setup_wizard.js +++ b/frappe/desk/page/setup_wizard/setup_wizard.js @@ -404,7 +404,7 @@ frappe.setup.slides_settings = [ fieldname: "enable_telemetry", label: __("Allow sending usage data for improving applications"), fieldtype: "Check", - default: 1, + default: cint(frappe.telemetry.can_enable()), depends_on: "eval:frappe.telemetry.can_enable()", }, { diff --git a/frappe/public/js/telemetry/index.js b/frappe/public/js/telemetry/index.js index 751c13994e..4c71b18f28 100644 --- a/frappe/public/js/telemetry/index.js +++ b/frappe/public/js/telemetry/index.js @@ -43,7 +43,7 @@ class TelemetryManager { } can_enable() { - return Boolean(this.telemetry_host && this.project_id); + return Boolean(this.telemetry_host && this.project_id && !cint(navigator.doNotTrack)); } send_heartbeat() {