From 8710d64c868428e257882670cec1c64d8d96fca7 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Thu, 10 Nov 2022 23:58:34 +0530 Subject: [PATCH] fix: no need to set random fieldname while adding column --- frappe/public/js/form_builder/components/Column.vue | 8 ++++---- frappe/public/js/form_builder/utils.js | 7 +++---- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/frappe/public/js/form_builder/components/Column.vue b/frappe/public/js/form_builder/components/Column.vue index f8c76295b9..2de85f641e 100644 --- a/frappe/public/js/form_builder/components/Column.vue +++ b/frappe/public/js/form_builder/components/Column.vue @@ -14,8 +14,8 @@ function add_column() { // insert new column after the current column let index = props.section.columns.indexOf(props.column); props.section.columns.splice(index + 1, 0, { - df: store.get_df("Column Break", "column_break_" + frappe.utils.get_random(4)), - fields: [] + df: store.get_df("Column Break"), + fields: [], }); } @@ -36,9 +36,9 @@ function remove_column() { if (props.column.fields.length != 0) { // create a new column if current column has fields and push fields to it columns.unshift({ - df: store.get_df("Column Break", "column_break_" + frappe.utils.get_random(4)), + df: store.get_df("Column Break"), fields: props.column.fields, - is_first: true + is_first: true, }); index++; } else { diff --git a/frappe/public/js/form_builder/utils.js b/frappe/public/js/form_builder/utils.js index 5b3ec2842c..1a684f8405 100644 --- a/frappe/public/js/form_builder/utils.js +++ b/frappe/public/js/form_builder/utils.js @@ -51,8 +51,7 @@ export function create_layout(fields) { function get_new_column(df) { let _column = {}; - _column.df = - df || store.get_df("Column Break", "column_break_" + frappe.utils.get_random(4)); + _column.df = df || store.get_df("Column Break"); _column.fields = []; _column.is_first = !df; return _column; @@ -169,11 +168,11 @@ export function section_boilerplate() { df: store.get_df("Section Break"), columns: [ { - df: store.get_df("Column Break", "column_break_" + frappe.utils.get_random(4)), + df: store.get_df("Column Break"), fields: [], }, { - df: store.get_df("Column Break", "column_break_" + frappe.utils.get_random(4)), + df: store.get_df("Column Break"), fields: [], }, ],