vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Only clear doctype cache if specified (#21611)

Browse source
This commit is contained in:
Ankush Menat 2023-07-09 10:44:43 +05:30 • committed by GitHub
parent cb156b6f24
commit 8730de41f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/cache_manager.py
View file

@ -120,13 +120,13 @@ def clear_defaults_cache(user=None):
def clear_doctype_cache(doctype=None):
clear_controller_cache(doctype)
_clear_doctype_cache_form_redis()
_clear_doctype_cache_from_redis(doctype)
if hasattr(frappe.db, "after_commit"):
frappe.db.after_commit.add(_clear_doctype_cache_form_redis)
frappe.db.after_rollback.add(_clear_doctype_cache_form_redis)
frappe.db.after_commit.add(lambda: _clear_doctype_cache_from_redis(doctype))
frappe.db.after_rollback.add(lambda: _clear_doctype_cache_from_redis(doctype))
def _clear_doctype_cache_form_redis(doctype: str | None = None):
def _clear_doctype_cache_from_redis(doctype: str | None = None):
from frappe.desk.notifications import delete_notification_count_for
for key in ("is_table", "doctype_modules"):

3
frappe/tests/test_perf.py
View file

@ -46,7 +46,9 @@ class TestPerformance(FrappeTestCase):
self.reset_request_specific_caches()
def test_meta_caching(self):
frappe.clear_cache()
frappe.get_meta("User")
frappe.clear_cache(doctype="ToDo")
with self.assertQueryCount(0):
frappe.get_meta("User")
@ -131,7 +133,6 @@ class TestPerformance(FrappeTestCase):
f"Possible performance regression in basic /api/Resource list requests",
)
@unittest.skip("Not implemented")
def test_homepage_resolver(self):
paths = ["/", "/app"]
for path in paths: