From 8788a43b3532b92e2bbd71b834af6df2804d7afc Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Fri, 18 Dec 2020 09:52:17 +0530
Subject: [PATCH] fix: Show edit option based on permission

---
 .../js/frappe/form/footer/form_timeline.js    | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/frappe/public/js/frappe/form/footer/form_timeline.js b/frappe/public/js/frappe/form/footer/form_timeline.js
index 80fb54f339..72c1be9a53 100644
--- a/frappe/public/js/frappe/form/footer/form_timeline.js
+++ b/frappe/public/js/frappe/form/footer/form_timeline.js
@@ -329,11 +329,14 @@ class FormTimeline extends BaseTimeline {
 		let edit_box = this.make_editable(edit_wrapper);
 		let content_wrapper = comment_wrapper.find('.content');
 
-		let delete_button = $(`
-			<button class="btn btn-link action-btn">
-				${frappe.utils.icon('close', 'sm')}
-			</button>
-		`).click(() => this.delete_comment(doc.name));
+		let delete_button = $();
+		if (frappe.model.can_delete("Comment")) {
+			delete_button = $(`
+				<button class="btn btn-link action-btn">
+					${frappe.utils.icon('close', 'sm')}
+				</button>
+			`).click(() => this.delete_comment(doc.name));
+		}
 
 		let dismiss_button = $(`
 			<button class="btn btn-link action-btn">
@@ -361,9 +364,13 @@ class FormTimeline extends BaseTimeline {
 
 		content_wrapper.after(edit_wrapper);
 
-		let edit_button = $(`<button class="btn btn-link action-btn">${__("Edit")}</a>`).click(() => {
-			edit_button.edit_mode ? edit_box.submit() : edit_button.toggle_edit_mode();
-		});
+		let edit_button = $();
+		let current_user = frappe.session.user;
+		if (['Administrator', doc.owner].includes(current_user)) {
+			edit_button = $(`<button class="btn btn-link action-btn">${__("Edit")}</a>`).click(() => {
+				edit_button.edit_mode ? edit_box.submit() : edit_button.toggle_edit_mode();
+			});
+		}
 
 		edit_button.toggle_edit_mode = () => {
 			edit_button.edit_mode = !edit_button.edit_mode;