From 8830141faf5b86ae7847330c642df8c2b82c6fea Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Mon, 7 Mar 2022 11:10:21 +0100 Subject: [PATCH] refactor: reduce code duplication Co-authored-by: gavin --- frappe/desk/query_report.py | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/frappe/desk/query_report.py b/frappe/desk/query_report.py index c9c2d4a4cc..d9bf4f70fa 100644 --- a/frappe/desk/query_report.py +++ b/frappe/desk/query_report.py @@ -383,18 +383,11 @@ def handle_duration_fieldtype_values(result, columns): if fieldtype != "Duration": continue - for entry in range(0, len(result)): - row = result[entry] - if isinstance(row, dict): - val_in_seconds = row[col.fieldname] - if val_in_seconds: - duration_val = format_duration(val_in_seconds) - row[col.fieldname] = duration_val - else: - val_in_seconds = row[i] - if val_in_seconds: - duration_val = format_duration(val_in_seconds) - row[i] = duration_val + for row in result: + index = col.fieldname if isinstance(row, dict) else i + val_in_seconds = row[index] + if val_in_seconds: + row[index] = format_duration(val_in_seconds) return result