From 890f5dd5975b28db8b225e75a6da24b58ad22555 Mon Sep 17 00:00:00 2001
From: Ankush Menat <ankush@frappe.io>
Date: Tue, 31 May 2022 14:49:12 +0530
Subject: [PATCH] fix: misc client side errors (#17018)

* fix: group by button color consistency with filter

* fix: return promise from HTML.set_value

* fix: only call set_input if control supports input
---
 frappe/public/js/frappe/form/controls/html.js | 1 +
 frappe/public/js/frappe/ui/field_group.js     | 2 +-
 frappe/public/scss/desk/report.scss           | 4 ++--
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/frappe/public/js/frappe/form/controls/html.js b/frappe/public/js/frappe/form/controls/html.js
index b2f18d4ccc..4cc0e4ab50 100644
--- a/frappe/public/js/frappe/form/controls/html.js
+++ b/frappe/public/js/frappe/form/controls/html.js
@@ -28,5 +28,6 @@ frappe.ui.form.ControlHTML = class ControlHTML extends frappe.ui.form.Control {
 			this.df.options = html;
 			this.html(html);
 		}
+		return Promise.resolve();
 	}
 };
diff --git a/frappe/public/js/frappe/ui/field_group.js b/frappe/public/js/frappe/ui/field_group.js
index cba702407a..c226c4cbfb 100644
--- a/frappe/public/js/frappe/ui/field_group.js
+++ b/frappe/public/js/frappe/ui/field_group.js
@@ -132,7 +132,7 @@ frappe.ui.FieldGroup = class FieldGroup extends frappe.ui.form.Layout {
 			var f = this.fields_dict[key];
 			if (f) {
 				f.set_value(val).then(() => {
-					f.set_input(val);
+					f.set_input?.(val);
 					this.refresh_dependency();
 					resolve();
 				});
diff --git a/frappe/public/scss/desk/report.scss b/frappe/public/scss/desk/report.scss
index f8666602ff..8ed0fb740c 100644
--- a/frappe/public/scss/desk/report.scss
+++ b/frappe/public/scss/desk/report.scss
@@ -104,12 +104,12 @@
 }
 
 .group-by-button.btn-primary-light {
-	color: var(--blue-500);
+	color: var(--text-on-blue);
 }
 
 .group-by-icon.active {
 	use {
-		stroke: var(--blue-500);
+		stroke: var(--text-on-blue);
 	}
 }