From 892c5e30a2804770d0cacd7660afa463bf103b1f Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 19 Jul 2023 16:31:00 +0530 Subject: [PATCH] refactor: Simpler workflow caching Entire document is cached, so no need to create another layer of cache. --- frappe/model/workflow.py | 6 +----- frappe/workflow/doctype/workflow/workflow.py | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/frappe/model/workflow.py b/frappe/model/workflow.py index 0e345a6515..0d7ce13d95 100644 --- a/frappe/model/workflow.py +++ b/frappe/model/workflow.py @@ -228,11 +228,7 @@ def send_email_alert(workflow_name): def get_workflow_field_value(workflow_name, field): - value = frappe.cache.hget("workflow_" + workflow_name, field) - if value is None: - value = frappe.db.get_value("Workflow", workflow_name, field) - frappe.cache.hset("workflow_" + workflow_name, field, value) - return value + return frappe.get_cached_value("Workflow", workflow_name, field) @frappe.whitelist() diff --git a/frappe/workflow/doctype/workflow/workflow.py b/frappe/workflow/doctype/workflow/workflow.py index 56c17261b7..c28d5e4cd9 100644 --- a/frappe/workflow/doctype/workflow/workflow.py +++ b/frappe/workflow/doctype/workflow/workflow.py @@ -17,7 +17,6 @@ class Workflow(Document): def on_update(self): self.update_doc_status() frappe.clear_cache(doctype=self.document_type) - frappe.cache.delete_key("workflow_" + self.name) # clear cache created in model/workflow.py def create_custom_field_for_workflow_state(self): frappe.clear_cache(doctype=self.document_type)