From 8a0825fe6d7bb849b7ca8598788d9c69d63ab43c Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 8 Apr 2026 21:27:43 +0530 Subject: [PATCH] test: don't hardcode throw-away doctype names --- frappe/tests/test_document.py | 34 ++++++++++++++++------------------ 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/frappe/tests/test_document.py b/frappe/tests/test_document.py index 94e2f0e643..e28ca060c0 100644 --- a/frappe/tests/test_document.py +++ b/frappe/tests/test_document.py @@ -824,12 +824,9 @@ class TestGetDocs(IntegrationTestCase): cls.child_dt = "Test Get Docs Child" cls.parent_dt = "Test Get Docs Parent" - if not frappe.db.exists("DocType", cls.child_dt): - new_doctype(name=cls.child_dt, istable=1).insert() - - if not frappe.db.exists("DocType", cls.parent_dt): + cls.child_dt = new_doctype(istable=1).insert().name + cls.parent_dt = ( new_doctype( - name=cls.parent_dt, fields=[ {"fieldtype": "Data", "fieldname": "title", "label": "Title"}, { @@ -839,21 +836,22 @@ class TestGetDocs(IntegrationTestCase): "label": "Child Table", }, ], + ) + .insert() + .name + ) + for i in range(5): + frappe.get_doc( + { + "doctype": cls.parent_dt, + "title": f"Record {i}", + "child_table": [ + {"some_fieldname": f"child_{i}_0"}, + {"some_fieldname": f"child_{i}_1"}, + ], + } ).insert() - if not frappe.db.count(cls.parent_dt): - for i in range(5): - frappe.get_doc( - { - "doctype": cls.parent_dt, - "title": f"Record {i}", - "child_table": [ - {"some_fieldname": f"child_{i}_0"}, - {"some_fieldname": f"child_{i}_1"}, - ], - } - ).insert() - @classmethod def tearDownClass(cls): frappe.db.delete(cls.child_dt)