From 8a264d05cacf8501dab393f009aa899190e5f7d2 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Tue, 15 Feb 2022 13:02:20 +0530 Subject: [PATCH] fix: remove `ignore_in_getter`; cleaner implementation --- frappe/model/base_document.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/frappe/model/base_document.py b/frappe/model/base_document.py index f6b7d05079..d55ed6cbd2 100644 --- a/frappe/model/base_document.py +++ b/frappe/model/base_document.py @@ -73,8 +73,7 @@ def get_controller(doctype): return site_controllers[doctype] class BaseDocument(object): - ignore_in_getter = ("doctype", "_meta", "meta", "_table_fields", "_valid_columns") - ignore_in_setter = ("doctype",) + ignore_in_setter = ("doctype", "_meta", "meta", "_table_fields", "_valid_columns") def __init__(self, d): if d.get("doctype"): @@ -148,10 +147,11 @@ class BaseDocument(object): else: value = self.__dict__.get(key, default) - if value is None and key not in self.ignore_in_getter \ - and key in (d.fieldname for d in self.meta.get_table_fields()): - self.set(key, []) - value = self.__dict__.get(key) + if value is None and key in ( + d.fieldname for d in self.meta.get_table_fields() + ): + value = [] + self.set(key, value) return value else: