vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: consider fixed tabs list height for correct vertical offset

Browse source
This commit is contained in:
Gursheen Anand 2026-02-25 18:39:04 +05:30
parent d862716267
commit 8a2dca535e
1 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
frappe/public/js/frappe/utils/utils.js
View file

@ -328,7 +328,7 @@ Object.assign(frappe.utils, {
scroll_top =
typeof element == "number"
? element - cint(additional_offset)
: this.get_scroll_position(element, element_to_be_scrolled, additional_offset);
: this.get_scroll_position(element, additional_offset, element_to_be_scrolled);
}
if (scroll_top < 0) {
@ -366,8 +366,8 @@ Object.assign(frappe.utils, {
element_to_be_scrolled.scrollTop(scroll_top);
}
},
get_scroll_position: function (element, element_to_be_scrolled, additional_offset) {
function getOffsetRelativeToContainer() {
get_scroll_position: function (element, additional_offset, element_to_be_scrolled) {
const get_offset_relative_to_container = () => {
let offset = 0;
let el = element instanceof HTMLElement ? element : element[0];
@ -379,12 +379,19 @@ Object.assign(frappe.utils, {
}
return offset;
}
};
const get_header_offset = () => {
const navbar_height = $(".navbar").height() || 0;
const page_head_height = $(".page-head:visible").height() || 0;
const tabs_container_height = $(".form-tabs-list:visible").height() || 0;
return navbar_height + page_head_height + tabs_container_height;
};
const element_offset_top = get_offset_relative_to_container();
const header_offset = get_header_offset();
const navbar_height = $(".navbar").height() || 0;
const page_head_height = $(".page-head:visible").height() || 0;
const header_offset = navbar_height + page_head_height;
const element_offset_top = getOffsetRelativeToContainer();
return element_offset_top - header_offset - cint(additional_offset);
},
filter_dict: function (dict, filters) {