From 8aedf6410a3dc401a4153f7676dbcce0d55084ec Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Fri, 18 Feb 2022 20:17:39 +0530 Subject: [PATCH] fix: None is not NoneType * also, rename test ;) --- frappe/model/rename_doc.py | 2 +- frappe/tests/test_rename_doc.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/model/rename_doc.py b/frappe/model/rename_doc.py index ffd43fb1c7..88752103ae 100644 --- a/frappe/model/rename_doc.py +++ b/frappe/model/rename_doc.py @@ -30,7 +30,7 @@ def update_document_title( """ # TODO: omit this after runtime type checking (ref: https://github.com/frappe/frappe/pull/14927) for obj in [docname, new_name, new_title, old_title]: - if not isinstance(obj, (str, None)): + if not isinstance(obj, (str, type(None))): frappe.throw(f"{obj} must be of type str or None") frappe.has_permission(doctype, ptype="write", throw=True) diff --git a/frappe/tests/test_rename_doc.py b/frappe/tests/test_rename_doc.py index ef3348b01f..e86bd9cde2 100644 --- a/frappe/tests/test_rename_doc.py +++ b/frappe/tests/test_rename_doc.py @@ -185,7 +185,7 @@ class TestRenameDoc(unittest.TestCase): new_name, frappe.rename_doc("Renamed Doc", old_name, new_name, force=True) ) - def test_update_title_api(self): + def test_update_document_title_api(self): from frappe.model.rename_doc import update_document_title allow_rename_prop = frappe.db.get_value("DocType", self.test_doctype, "allow_rename") frappe.clear_cache()