From 8b2e4a5f4cb2d94d7152b1f3b6dedf3fad338f2e Mon Sep 17 00:00:00 2001 From: ci2014 Date: Fri, 4 May 2018 09:45:30 +0200 Subject: [PATCH] Check for list_renderer before accessing settings (#5469) * Check for list_renderer before accessing settings In the master version of frappe, in the first attempt of calling the file manager (when onload is called) the report doesn't build, because in the report view, there is no such attribute list_renderer available. In that change we check if the list renderer is not undefined and only setup the menu, drag and drop and copy function, when the list_renderer object is available. This problem might not occur in the developer versions (datatables), but many people still work with the master version and need a working file manager report. * Update file_list.js --- frappe/core/doctype/file/file_list.js | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/frappe/core/doctype/file/file_list.js b/frappe/core/doctype/file/file_list.js index 61b4a58a0c..ea117fddeb 100644 --- a/frappe/core/doctype/file/file_list.js +++ b/frappe/core/doctype/file/file_list.js @@ -38,12 +38,15 @@ frappe.listview_settings['File'] = { doclist.breadcrumb = $('
    ') .insertBefore(doclist.filter_area); - doclist.list_renderer.settings.setup_menu(doclist); - doclist.list_renderer.settings.setup_dragdrop(doclist); + + if (doclist.list_renderer) { + doclist.list_renderer.settings.setup_menu(doclist); + doclist.list_renderer.settings.setup_dragdrop(doclist); - doclist.$page.on("click", ".list-row-checkbox", function(event) { - doclist.list_renderer.settings.add_menu_item_copy(doclist); - }); + doclist.$page.on("click", ".list-row-checkbox", function(event) { + doclist.list_renderer.settings.add_menu_item_copy(doclist); + }); + } }, list_view_doc:function(doclist){ $(doclist.wrapper).on("click", 'button[list_view_doc="'+doclist.doctype+'"]', function() {