vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: check for running jobs before migrating (#31438)

Browse source
This commit is contained in:
Ankush Menat 2025-02-26 15:00:38 +05:30 • committed by GitHub
parent 8102706116
commit 8baeb5151d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frappe/commands/scheduler.py
View file

@ -233,6 +233,8 @@ def start_worker_pool(queue, quiet=False, num_workers=2, burst=False):
@click.option("--site", help="site name")
@pass_context
def ready_for_migration(context: CliCtxObj, site=None):
import time
from frappe.utils.doctor import any_job_pending
if not site:
@ -240,7 +242,14 @@ def ready_for_migration(context: CliCtxObj, site=None):
try:
frappe.init(site)
pending_jobs = any_job_pending(site=site)
pending_jobs = False
# HACK: Check at least 3 times, 1 second apart.
# Rare edge case: Scheduler hasn't seen 'maintenance_mode=1` yet
# and takes more than 3 second to schedule.
for _ in range(3):
pending_jobs |= any_job_pending(site=site)
time.sleep(1)
if pending_jobs:
print(f"NOT READY for migration: site {site} has pending background jobs")

6
frappe/utils/doctor.py
View file

@ -80,9 +80,15 @@ def get_pending_jobs(site=None):
def any_job_pending(site: str) -> bool:
for queue in get_queue_list():
q = get_queue(queue)
# pending jobs
for job_id in q.get_job_ids():
if job_id.startswith(site):
return True
# already running jobs
for job_id in q.started_job_registry.get_job_ids():
if job_id.startswith(site):
return True
return False