fix: Show deprecation warnings only if DEV_SERVER is set

This will show warnings in bench start commands by default as this
envvar is set.
This commit is contained in:
Gavin D'souza 2021-05-19 13:16:16 +05:30
parent 2dde3a9b01
commit 8cc6804850
3 changed files with 12 additions and 6 deletions

View file

@ -10,9 +10,16 @@ be used to build database driven apps.
Read the documentation: https://frappeframework.com/docs
"""
import os, warnings
_dev_server = os.environ.get('DEV_SERVER', False)
if _dev_server:
warnings.simplefilter('always', DeprecationWarning)
warnings.simplefilter('always', PendingDeprecationWarning)
from werkzeug.local import Local, release_local
import os, sys, importlib, inspect, json, warnings
import sys, importlib, inspect, json
import typing
from past.builtins import cmp
import click
@ -31,8 +38,6 @@ __title__ = "Frappe Framework"
local = Local()
controllers = {}
warnings.simplefilter('always', DeprecationWarning)
warnings.simplefilter('always', PendingDeprecationWarning)
class _dict(dict):
"""dict like object that exposes keys as attributes"""
@ -197,7 +202,7 @@ def init(site, sites_path=None, new_site=False):
local.meta_cache = {}
local.form_dict = _dict()
local.session = _dict()
local.dev_server = os.environ.get('DEV_SERVER', False)
local.dev_server = _dev_server
setup_module_map()

View file

@ -99,5 +99,6 @@ def get_apps():
return frappe.get_all_apps(with_internal_apps=False, sites_path='.')
if __name__ == "__main__":
warnings.simplefilter('ignore')
if not frappe._dev_server:
warnings.simplefilter('ignore')
main()

View file

@ -119,7 +119,7 @@ def get_safe_globals():
scrub=scrub,
guess_mimetype=mimetypes.guess_type,
html2text=html2text,
dev_server=1 if os.environ.get('DEV_SERVER', False) else 0,
dev_server=1 if frappe._dev_server else 0,
run_script=run_script
)