vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Kanban Board Menu Items Accessibility via perms

Browse source 
- Save Filters and Delete Board btns render if 'write' and 'delete' perms exist on Kanban Board
- `Create Kanban Board` renders only if 'create' perms exist on Kanban Board
- Bind board permisions to `board_perms` property of board object
- Get perms via backend call at board initialization, as frontend does not have document object (only doctype meta and perms are cached)
This commit is contained in:
marination 2022-11-17 18:46:45 +05:30
parent 299831d209
commit 8d31e702e8
3 changed files with 55 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
frappe/public/js/frappe/list/list_view_select.js
View file

@ -191,12 +191,16 @@ frappe.views.ListViewSelect = class ListViewSelect {
);
});
this.page.add_custom_menu_item(
kanban_switcher,
__("Create New Kanban Board"),
() => frappe.views.KanbanView.show_kanban_dialog(this.doctype),
true
);
let perms = this.list_view.board_perms;
let can_create = perms ? perms.create : true;
if (can_create) {
this.page.add_custom_menu_item(
kanban_switcher,
__("Create New Kanban Board"),
() => frappe.views.KanbanView.show_kanban_dialog(this.doctype),
true
);
}
}
get_page_name() {

2
frappe/public/js/frappe/views/kanban/kanban_board.bundle.js
View file

@ -519,7 +519,7 @@ frappe.provide("frappe.views");
function init() {
make_dom();
// setup_sortable(); // drag card
setup_sortable(); // drag card
make_cards();
store.watch((state, getters) => {
return state.cards;

68
frappe/public/js/frappe/views/kanban/kanban_view.js
View file

@ -56,33 +56,53 @@ frappe.views.KanbanView = class KanbanView extends frappe.views.ListView {
this.card_meta = this.get_card_meta();
this.page_length = 0;
// frappe run serially get/set perms > push menu items > get_board
this.menu_items.push(
...[
{
label: __("Save filters"),
action: () => {
this.save_kanban_board_filters();
},
},
{
label: __("Delete Kanban Board"),
action: () => {
frappe.confirm("Are you sure you want to proceed?", () => {
frappe.db.delete_doc("Kanban Board", this.board_name).then(() => {
frappe.show_alert(`Kanban Board ${this.board_name} deleted.`);
frappe.set_route("List", this.doctype, "List");
});
});
},
},
]
);
return this.get_board();
return frappe.run_serially([
() => this.set_board_perms_and_push_menu_items(),
() => this.get_board(),
]);
});
}
set_board_perms_and_push_menu_items() {
// needs server-side call as client-side document instance is absent before kanban render
return frappe.call({
method: "frappe.client.get_doc_permissions",
args: {
doctype: "Kanban Board",
docname: this.board_name
},
callback: (result) => {
this.board_perms = result.message.permissions || {};
this.push_menu_items();
},
});
}
push_menu_items() {
if (this.board_perms.write) {
this.menu_items.push({
label: __("Save filters"),
action: () => {
this.save_kanban_board_filters();
}
});
}
if (this.board_perms.delete) {
this.menu_items.push({
label: __("Delete Kanban Board"),
action: () => {
frappe.confirm("Are you sure you want to proceed?", () => {
frappe.db.delete_doc("Kanban Board", this.board_name).then(() => {
frappe.show_alert(`Kanban Board ${this.board_name} deleted.`);
frappe.set_route("List", this.doctype, "List");
});
});
},
});
}
}
setup_paging_area() {
// pass
}